* [PATCH v2 net-next] net:mv88e6xxx: use g2 interrupt for 6097 chip
@ 2017-01-03 15:18 Volodymyr Bendiuga
2017-01-03 16:18 ` David Miller
2017-01-03 16:28 ` Andrew Lunn
0 siblings, 2 replies; 3+ messages in thread
From: Volodymyr Bendiuga @ 2017-01-03 15:18 UTC (permalink / raw)
To: andrew, vivien.didelot, f.fainelli, netdev, volodymyr.bendiuga
From: Volodymyr Bendiuga <volodymyr.bendiuga@westermo.se>
This chip needs MV88E6XXX_FLAG_G2_INT
Signed-off-by: Volodymyr Bendiuga <volodymyr.bendiuga@westermo.se>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
index af54bae..431e954 100644
--- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
+++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
@@ -566,6 +566,7 @@ enum mv88e6xxx_cap {
(MV88E6XXX_FLAG_G1_ATU_FID | \
MV88E6XXX_FLAG_G1_VTU_FID | \
MV88E6XXX_FLAG_GLOBAL2 | \
+ MV88E6XXX_FLAG_G2_INT | \
MV88E6XXX_FLAG_G2_MGMT_EN_2X | \
MV88E6XXX_FLAG_G2_MGMT_EN_0X | \
MV88E6XXX_FLAG_G2_POT | \
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2 net-next] net:mv88e6xxx: use g2 interrupt for 6097 chip
2017-01-03 15:18 [PATCH v2 net-next] net:mv88e6xxx: use g2 interrupt for 6097 chip Volodymyr Bendiuga
@ 2017-01-03 16:18 ` David Miller
2017-01-03 16:28 ` Andrew Lunn
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-01-03 16:18 UTC (permalink / raw)
To: volodymyr.bendiuga
Cc: andrew, vivien.didelot, f.fainelli, netdev, volodymyr.bendiuga
From: Volodymyr Bendiuga <volodymyr.bendiuga@gmail.com>
Date: Tue, 3 Jan 2017 16:18:40 +0100
> + MV88E6XXX_FLAG_G2_INT | \
Space before TAB character is still there on this line, right after
the "+".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 net-next] net:mv88e6xxx: use g2 interrupt for 6097 chip
2017-01-03 15:18 [PATCH v2 net-next] net:mv88e6xxx: use g2 interrupt for 6097 chip Volodymyr Bendiuga
2017-01-03 16:18 ` David Miller
@ 2017-01-03 16:28 ` Andrew Lunn
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2017-01-03 16:28 UTC (permalink / raw)
To: Volodymyr Bendiuga; +Cc: vivien.didelot, f.fainelli, netdev, volodymyr.bendiuga
On Tue, Jan 03, 2017 at 04:18:40PM +0100, Volodymyr Bendiuga wrote:
> From: Volodymyr Bendiuga <volodymyr.bendiuga@westermo.se>
>
> This chip needs MV88E6XXX_FLAG_G2_INT
>
> Signed-off-by: Volodymyr Bendiuga <volodymyr.bendiuga@westermo.se>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> ---
> drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
> index af54bae..431e954 100644
> --- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
> +++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h
> @@ -566,6 +566,7 @@ enum mv88e6xxx_cap {
> (MV88E6XXX_FLAG_G1_ATU_FID | \
> MV88E6XXX_FLAG_G1_VTU_FID | \
> MV88E6XXX_FLAG_GLOBAL2 | \
> + MV88E6XXX_FLAG_G2_INT | \
checkpatch is your friend:
$ ./scripts/checkpatch.pl volodymyr.bendiuga
ERROR: code indent should use tabs where possible
#76: FILE: drivers/net/dsa/mv88e6xxx/mv88e6xxx.h:569:
+ ^I MV88E6XXX_FLAG_G2_INT |^I\$
WARNING: please, no space before tabs
#76: FILE: drivers/net/dsa/mv88e6xxx/mv88e6xxx.h:569:
+ ^I MV88E6XXX_FLAG_G2_INT |^I\$
WARNING: please, no spaces at the start of a line
#76: FILE: drivers/net/dsa/mv88e6xxx/mv88e6xxx.h:569:
+ ^I MV88E6XXX_FLAG_G2_INT |^I\$
total: 1 errors, 2 warnings, 0 checks, 7 lines checked
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-03 16:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-03 15:18 [PATCH v2 net-next] net:mv88e6xxx: use g2 interrupt for 6097 chip Volodymyr Bendiuga
2017-01-03 16:18 ` David Miller
2017-01-03 16:28 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).