From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
cphealy@gmail.com
Subject: Re: [PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2
Date: Tue, 3 Jan 2017 19:33:52 +0100 [thread overview]
Message-ID: <20170103183352.GA30638@lunn.ch> (raw)
In-Reply-To: <20170103181538.2593-1-vivien.didelot@savoirfairelinux.com>
On Tue, Jan 03, 2017 at 01:15:35PM -0500, Vivien Didelot wrote:
> The current HWMON support in DSA in embedded in the legacy code.
> Extract it to its own file and register it in the newer DSA code.
Hi Vivien
I would really prefer not to do this.
The temperature sensor is in the embedded PHYs of the switch. Many of
Marvell discrete PHYs also have the same temperature sensor. The
correct thing to do is move this code into drivers/net/phy/marvell.c.
Andrew
next prev parent reply other threads:[~2017-01-03 18:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 18:15 [PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2 Vivien Didelot
2017-01-03 18:15 ` [PATCH net-next 1/3] net: dsa: remove out label in dsa_switch_setup_one Vivien Didelot
2017-01-03 18:39 ` Andrew Lunn
2017-01-03 19:18 ` Vivien Didelot
2017-01-03 18:15 ` [PATCH net-next 2/3] net: dsa: move HWMON support to its own file Vivien Didelot
2017-01-03 22:33 ` kbuild test robot
2017-01-03 18:15 ` [PATCH net-next 3/3] net: dsa: restore HWMON support in dsa2 Vivien Didelot
2017-01-03 18:33 ` Andrew Lunn [this message]
2017-01-03 19:24 ` [PATCH net-next 0/3] " Vivien Didelot
2017-01-03 19:29 ` Florian Fainelli
2017-01-03 19:41 ` Vivien Didelot
2017-01-03 20:09 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103183352.GA30638@lunn.ch \
--to=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).