* [PATCH] LiquidIO VF: s/select/imply/ for PTP_1588_CLOCK
[not found] <20170103101105.GA24780@localhost.localdomain>
@ 2017-01-03 18:57 ` Nicolas Pitre
2017-01-03 19:24 ` Richard Cochran
2017-01-04 18:27 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Pitre @ 2017-01-03 18:57 UTC (permalink / raw)
To: Richard Cochran, Raghu Vatsavayi, David S. Miller; +Cc: netdev
Fix a minor fallout from the merge of the timers and the networking
trees. The following error may result if the PTP_1588_CLOCK
prerequisites are not available:
drivers/built-in.o: In function `ptp_clock_unregister':
(.text+0x40e0a5): undefined reference to `pps_unregister_source'
drivers/built-in.o: In function `ptp_clock_unregister':
(.text+0x40e0cc): undefined reference to `posix_clock_unregister'
drivers/built-in.o: In function `ptp_clock_event':
(.text+0x40e249): undefined reference to `pps_event'
drivers/built-in.o: In function `ptp_clock_register':
(.text+0x40e5e1): undefined reference to `pps_register_source'
drivers/built-in.o: In function `ptp_clock_register':
(.text+0x40e62c): undefined reference to `posix_clock_register'
drivers/built-in.o: In function `ptp_clock_register':
(.text+0x40e68d): undefined reference to `pps_unregister_source'
Signed-off-by: Nicolas Pitre <nico@linaro.org>
diff --git a/drivers/net/ethernet/cavium/Kconfig b/drivers/net/ethernet/cavium/Kconfig
index bbc8bd16cb..dcbce6cac6 100644
--- a/drivers/net/ethernet/cavium/Kconfig
+++ b/drivers/net/ethernet/cavium/Kconfig
@@ -77,7 +77,7 @@ config OCTEON_MGMT_ETHERNET
config LIQUIDIO_VF
tristate "Cavium LiquidIO VF support"
depends on 64BIT && PCI_MSI
- select PTP_1588_CLOCK
+ imply PTP_1588_CLOCK
---help---
This driver supports Cavium LiquidIO Intelligent Server Adapter
based on CN23XX chips.
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] LiquidIO VF: s/select/imply/ for PTP_1588_CLOCK
2017-01-03 18:57 ` [PATCH] LiquidIO VF: s/select/imply/ for PTP_1588_CLOCK Nicolas Pitre
@ 2017-01-03 19:24 ` Richard Cochran
2017-01-04 18:27 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Richard Cochran @ 2017-01-03 19:24 UTC (permalink / raw)
To: Nicolas Pitre; +Cc: Raghu Vatsavayi, David S. Miller, netdev
On Tue, Jan 03, 2017 at 01:57:00PM -0500, Nicolas Pitre wrote:
> Fix a minor fallout from the merge of the timers and the networking
> trees. The following error may result if the PTP_1588_CLOCK
> prerequisites are not available:
>
> drivers/built-in.o: In function `ptp_clock_unregister':
> (.text+0x40e0a5): undefined reference to `pps_unregister_source'
> drivers/built-in.o: In function `ptp_clock_unregister':
> (.text+0x40e0cc): undefined reference to `posix_clock_unregister'
> drivers/built-in.o: In function `ptp_clock_event':
> (.text+0x40e249): undefined reference to `pps_event'
> drivers/built-in.o: In function `ptp_clock_register':
> (.text+0x40e5e1): undefined reference to `pps_register_source'
> drivers/built-in.o: In function `ptp_clock_register':
> (.text+0x40e62c): undefined reference to `posix_clock_register'
> drivers/built-in.o: In function `ptp_clock_register':
> (.text+0x40e68d): undefined reference to `pps_unregister_source'
>
> Signed-off-by: Nicolas Pitre <nico@linaro.org>
Thanks for following up on this.
Acked-by: Richard Cochran <richardcochran@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] LiquidIO VF: s/select/imply/ for PTP_1588_CLOCK
2017-01-03 18:57 ` [PATCH] LiquidIO VF: s/select/imply/ for PTP_1588_CLOCK Nicolas Pitre
2017-01-03 19:24 ` Richard Cochran
@ 2017-01-04 18:27 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-01-04 18:27 UTC (permalink / raw)
To: nicolas.pitre; +Cc: richardcochran, rvatsavayi, netdev
From: Nicolas Pitre <nicolas.pitre@linaro.org>
Date: Tue, 3 Jan 2017 13:57:00 -0500 (EST)
> Fix a minor fallout from the merge of the timers and the networking
> trees. The following error may result if the PTP_1588_CLOCK
> prerequisites are not available:
>
> drivers/built-in.o: In function `ptp_clock_unregister':
> (.text+0x40e0a5): undefined reference to `pps_unregister_source'
> drivers/built-in.o: In function `ptp_clock_unregister':
> (.text+0x40e0cc): undefined reference to `posix_clock_unregister'
> drivers/built-in.o: In function `ptp_clock_event':
> (.text+0x40e249): undefined reference to `pps_event'
> drivers/built-in.o: In function `ptp_clock_register':
> (.text+0x40e5e1): undefined reference to `pps_register_source'
> drivers/built-in.o: In function `ptp_clock_register':
> (.text+0x40e62c): undefined reference to `posix_clock_register'
> drivers/built-in.o: In function `ptp_clock_register':
> (.text+0x40e68d): undefined reference to `pps_unregister_source'
>
> Signed-off-by: Nicolas Pitre <nico@linaro.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-04 18:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170103101105.GA24780@localhost.localdomain>
2017-01-03 18:57 ` [PATCH] LiquidIO VF: s/select/imply/ for PTP_1588_CLOCK Nicolas Pitre
2017-01-03 19:24 ` Richard Cochran
2017-01-04 18:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).