From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>, John Crispin <john@phrozen.org>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
cphealy@gmail.com
Subject: Re: [PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2
Date: Tue, 3 Jan 2017 21:09:14 +0100 [thread overview]
Message-ID: <20170103200914.GB8765@lunn.ch> (raw)
In-Reply-To: <0a504cad-2f2c-fc6a-9965-5ae87be9dac4@gmail.com>
> Well, I agree with the regression part, but an argument could
> definitively be made that HWMON did not belong in the DSA layer in the
> first place, unless we were able to find some commonality between
> devices which AFAICT, we could not yet.
Florian, does SF2 or b53 have a temperature sensor?
John, does the qca8k have a temperature sensor?
If we do have a switch with a temperature sensor, making the HWMON
code available as a library for switch drivers to use makes sense.
However, if we move the Marvell code into the PHY driver, and there
are no other switches with temperature sensors, we should just remove
it.
Andrew
prev parent reply other threads:[~2017-01-03 20:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 18:15 [PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2 Vivien Didelot
2017-01-03 18:15 ` [PATCH net-next 1/3] net: dsa: remove out label in dsa_switch_setup_one Vivien Didelot
2017-01-03 18:39 ` Andrew Lunn
2017-01-03 19:18 ` Vivien Didelot
2017-01-03 18:15 ` [PATCH net-next 2/3] net: dsa: move HWMON support to its own file Vivien Didelot
2017-01-03 22:33 ` kbuild test robot
2017-01-03 18:15 ` [PATCH net-next 3/3] net: dsa: restore HWMON support in dsa2 Vivien Didelot
2017-01-03 18:33 ` [PATCH net-next 0/3] " Andrew Lunn
2017-01-03 19:24 ` Vivien Didelot
2017-01-03 19:29 ` Florian Fainelli
2017-01-03 19:41 ` Vivien Didelot
2017-01-03 20:09 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103200914.GB8765@lunn.ch \
--to=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=john@phrozen.org \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).