From: David Miller <davem@davemloft.net>
To: daniel@iogearbox.net
Cc: sowmini.varadhan@oracle.com, willemb@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] packet: fix panic in __packet_set_timestamp on tpacket_v3 in tx mode
Date: Wed, 04 Jan 2017 23:51:05 -0500 (EST) [thread overview]
Message-ID: <20170104.235105.547654899088862054.davem@davemloft.net> (raw)
In-Reply-To: <1483580068-13854-1-git-send-email-daniel@iogearbox.net>
From: Daniel Borkmann <daniel@iogearbox.net>
Date: Thu, 5 Jan 2017 02:34:28 +0100
> When TX timestamping is in use with TPACKET_V3's TX ring, then we'll
> hit the BUG() in __packet_set_timestamp() when ring buffer slot is
> returned to user space via tpacket_destruct_skb(). This is due to v3
> being assumed as unreachable here, but since 7f953ab2ba46 ("af_packet:
> TX_RING support for TPACKET_V3") it's not anymore. Fix it by filling
> the timestamp back into the ring slot.
>
> Fixes: 7f953ab2ba46 ("af_packet: TX_RING support for TPACKET_V3")
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Applied, thanks.
next prev parent reply other threads:[~2017-01-05 4:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 1:34 [PATCH net-next] packet: fix panic in __packet_set_timestamp on tpacket_v3 in tx mode Daniel Borkmann
2017-01-05 2:10 ` Sowmini Varadhan
2017-01-05 4:51 ` David Miller [this message]
2017-01-05 18:27 ` Eric Dumazet
2017-01-05 19:10 ` Daniel Borkmann
2017-03-06 17:13 ` chetan loke
2017-03-06 17:45 ` Willem de Bruijn
2017-03-06 21:36 ` chetan loke
2017-03-06 22:13 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104.235105.547654899088862054.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=sowmini.varadhan@oracle.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).