From: Jiri Benc <jbenc@redhat.com>
To: Pravin B Shelar <pshelar@ovn.org>
Cc: netdev@vger.kernel.org, Jarno Rajahalme <jarno@ovn.org>
Subject: Re: [PATCH net] openvswitch: upcall: Fix vlan handling.
Date: Wed, 4 Jan 2017 18:39:36 +0100 [thread overview]
Message-ID: <20170104183936.641518f7@griffin> (raw)
In-Reply-To: <1482769887-8022-1-git-send-email-pshelar@ovn.org>
On Mon, 26 Dec 2016 08:31:27 -0800, Pravin B Shelar wrote:
> Networking stack accelerate vlan tag handling by
> keeping topmost vlan header in skb. This works as
> long as packet remains in OVS datapath. But during
> OVS upcall vlan header is pushed on to the packet.
> When such packet is sent back to OVS datapath, core
> networking stack might not handle it correctly. Following
> patch avoids this issue by accelerating the vlan tag
> during flow key extract. This simplifies datapath by
> bringing uniform packet processing for packets from
> all code paths.
Sorry for the late review, I was off at the end of December. Just
wanted to say that the patch looks great.
Thanks!
Jiri
prev parent reply other threads:[~2017-01-04 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-26 16:31 [PATCH net] openvswitch: upcall: Fix vlan handling Pravin B Shelar
2016-12-27 17:29 ` David Miller
2017-01-04 17:39 ` Jiri Benc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104183936.641518f7@griffin \
--to=jbenc@redhat.com \
--cc=jarno@ovn.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).