From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sowmini Varadhan Subject: Re: [PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter Date: Wed, 4 Jan 2017 17:22:24 -0500 Message-ID: <20170104222224.GA31756@oracle.com> References: <3aa068fa482f7cf5381957e9a3ea58550822d1d1.1483555162.git.sowmini.varadhan@oracle.com> <586D7437.1050708@iogearbox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, willemb@google.com, davem@davemloft.net, shuah@kernel.org To: Daniel Borkmann Return-path: Received: from userp1050.oracle.com ([156.151.31.82]:16574 "EHLO userp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934831AbdADWYv (ORCPT ); Wed, 4 Jan 2017 17:24:51 -0500 Content-Disposition: inline In-Reply-To: <586D7437.1050708@iogearbox.net> Sender: netdev-owner@vger.kernel.org List-ID: On (01/04/17 23:16), Daniel Borkmann wrote: > > Just reading up on the thread, sorry to jump in late. Can't you just > use the generated code from bpf_asm (tools/net/) and add the asm program > as a comment above? Something like we do in net/core/ptp_classifier.c +13. I was actually using the example from the BSD bpf(4) man page, and expanding on that one.. https://www.freebsd.org/cgi/man.cgi?query=bpf&sektion=4&manpath=FreeBSD+4.7-RELEASE (I could not find the equivalent linux man page). It was a lot easier to parse than the existing code . > As it stands it makes it a bit harder to parse / less readable with macros > actually. Rest seems fine, thanks. You think the earlier code was readable? I had to use gcc -E, with help from the bpf(4) page, to make sense of it. --Sowmini