netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: Alexander.Loktionov@aquantia.com
Cc: netdev@vger.kernel.org, vomlehn@texas.net,
	Simon.Edelhaus@aquantia.com, Dmitrii.Tarakanov@aquantia.com,
	Pavel.Belous@aquantia.com
Subject: Re: [PATCH v2 00/12] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver
Date: Fri, 06 Jan 2017 16:02:06 -0500 (EST)	[thread overview]
Message-ID: <20170106.160206.1149383357421277805.davem@davemloft.net> (raw)
In-Reply-To: <cover.1483689029.git.vomlehn@texas.net>

From: Alexander Loktionov <Alexander.Loktionov@aquantia.com>
Date: Fri,  6 Jan 2017 00:06:01 -0800

> This series introduced the AQtion NIC driver for the aQuantia
> AQC107/AQC108 network devices.
> 
> v1: Initial version
> v2: o Make necessary drivers/net/ethernet changes to integrate software
>     o Drop intermediate atlantic directory
>     o Remove Makefile things only appropriate to out of tree module builidng

Every patch series must be fully bisectable, this means that at each step
of the series, the kernel tree must fully build and work properly.

You break that already at the first patch, which makes the Kconfig options
available, which if enabled will cause a build failure.

make[4]: *** No rule to make target 'drivers/net/ethernet/aquantia/aq_main.o', needed by 'drivers/net/ethernet/aquantia/atlantic.o'.  Stop.
make[4]: *** Waiting for unfinished jobs....
scripts/Makefile.build:551: recipe for target 'drivers/net/ethernet/aquantia' failed
make[3]: *** [drivers/net/ethernet/aquantia] Error 2
make[3]: *** Waiting for unfinished jobs....
scripts/Makefile.build:551: recipe for target 'drivers/net/ethernet' failed
make[2]: *** [drivers/net/ethernet] Error 2
scripts/Makefile.build:551: recipe for target 'drivers/net' failed
make[1]: *** [drivers/net] Error 2
make[1]: *** Waiting for unfinished jobs....
Makefile:988: recipe for target 'drivers' failed
make: *** [drivers] Error 2

The way to do this, is to add the pieces of source code infrastrucutre,
one piece at a time.  And then at the very very end, enable the code
into the build.

  parent reply	other threads:[~2017-01-06 21:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06  8:06 [PATCH v2 00/12] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver Alexander Loktionov
2017-01-06  8:06 ` [PATCH v2 01/12] net: ethernet: aquantia: Make and configuration files Alexander Loktionov
2017-01-06  8:06   ` [PATCH v2 02/12] net: ethernet: aquantia: Common functions and definitions Alexander Loktionov
2017-01-06  8:06     ` [PATCH v2 03/12] net: ethernet: aquantia: Add ring support code Alexander Loktionov
2017-01-06  8:06       ` [PATCH v2 04/12] net: ethernet: aquantia: Low-level hardware interfaces Alexander Loktionov
2017-01-06  8:06         ` [PATCH v2 05/12] net: ethernet: aquantia: Support for NIC-specific code Alexander Loktionov
2017-01-06  8:06           ` [PATCH v2 06/12] net: ethernet: aquantia: Atlantic A0 and B0 specific functions Alexander Loktionov
2017-01-06  8:06             ` [PATCH v2 07/12] net: ethernet: aquantia: Vector operations Alexander Loktionov
2017-01-06  8:06               ` [PATCH v2 08/12] net: ethernet: aquantia: PCI operations Alexander Loktionov
2017-01-06  8:06                 ` [PATCH v2 09/12] net: ethernet: aquantia: Atlantic hardware abstraction layer Alexander Loktionov
2017-01-06  8:06                   ` [PATCH v2 10/12] net: ethernet: aquantia: Hardware interface and utility functions Alexander Loktionov
2017-01-06  8:06                     ` [PATCH v2 11/12] net: ethernet: aquantia: Ethtool support Alexander Loktionov
2017-01-06  8:06                       ` [PATCH v2 12/12] net: ethernet: aquantia: Receive side scaling Alexander Loktionov
2017-01-07  4:31                         ` kbuild test robot
2017-01-07  5:49                         ` kbuild test robot
2017-01-07  9:48                         ` kbuild test robot
2017-01-07  8:31             ` [PATCH v2 06/12] net: ethernet: aquantia: Atlantic A0 and B0 specific functions kbuild test robot
2017-01-07  8:12           ` [PATCH v2 05/12] net: ethernet: aquantia: Support for NIC-specific code kbuild test robot
2017-01-07  7:03         ` [PATCH v2 04/12] net: ethernet: aquantia: Low-level hardware interfaces kbuild test robot
2017-01-07  1:05       ` [PATCH v2 03/12] net: ethernet: aquantia: Add ring support code Lino Sanfilippo
2017-01-08 23:18       ` Rami Rosen
2017-01-07  0:29     ` [PATCH v2 02/12] net: ethernet: aquantia: Common functions and definitions Lino Sanfilippo
2017-01-07  9:22   ` [PATCH v2 01/12] net: ethernet: aquantia: Make and configuration files kbuild test robot
2017-01-06 21:02 ` David Miller [this message]
2017-01-06 22:23   ` [PATCH v2 00/12] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver David VomLehn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170106.160206.1149383357421277805.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Alexander.Loktionov@aquantia.com \
    --cc=Dmitrii.Tarakanov@aquantia.com \
    --cc=Pavel.Belous@aquantia.com \
    --cc=Simon.Edelhaus@aquantia.com \
    --cc=netdev@vger.kernel.org \
    --cc=vomlehn@texas.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).