* [PATCH] vti6: fix device register to report IFLA_INFO_KIND
@ 2017-01-06 10:27 David Forster
2017-01-06 21:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: David Forster @ 2017-01-06 10:27 UTC (permalink / raw)
To: netdev; +Cc: Dave Forster
vti6 interface is registered before the rtnl_link_ops block
is attached. As a result the resulting RTM_NEWLINK is missing
IFLA_INFO_KIND. Re-order attachment of rtnl_link_ops block to fix.
Signed-off-by: Dave Forster <dforster@brocade.com>
---
net/ipv6/ip6_vti.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/ip6_vti.c b/net/ipv6/ip6_vti.c
index f4b4a4a..d82042c 100644
--- a/net/ipv6/ip6_vti.c
+++ b/net/ipv6/ip6_vti.c
@@ -189,12 +189,12 @@ static int vti6_tnl_create2(struct net_device *dev)
struct vti6_net *ip6n = net_generic(net, vti6_net_id);
int err;
+ dev->rtnl_link_ops = &vti6_link_ops;
err = register_netdevice(dev);
if (err < 0)
goto out;
strcpy(t->parms.name, dev->name);
- dev->rtnl_link_ops = &vti6_link_ops;
dev_hold(dev);
vti6_tnl_link(ip6n, t);
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vti6: fix device register to report IFLA_INFO_KIND
2017-01-06 10:27 [PATCH] vti6: fix device register to report IFLA_INFO_KIND David Forster
@ 2017-01-06 21:09 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-01-06 21:09 UTC (permalink / raw)
To: dforster; +Cc: netdev
From: David Forster <dforster@brocade.com>
Date: Fri, 6 Jan 2017 10:27:59 +0000
> vti6 interface is registered before the rtnl_link_ops block
> is attached. As a result the resulting RTM_NEWLINK is missing
> IFLA_INFO_KIND. Re-order attachment of rtnl_link_ops block to fix.
>
> Signed-off-by: Dave Forster <dforster@brocade.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-06 21:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-06 10:27 [PATCH] vti6: fix device register to report IFLA_INFO_KIND David Forster
2017-01-06 21:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).