netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: phil@nwl.cc
Cc: netdev@vger.kernel.org
Subject: Re: [net-next PATCH v6 0/3] net: dummy: Introduce dummy virtual functions
Date: Fri, 06 Jan 2017 20:38:04 -0500 (EST)	[thread overview]
Message-ID: <20170106.203804.2023763441703979123.davem@davemloft.net> (raw)
In-Reply-To: <20170105190913.29986-1-phil@nwl.cc>

From: Phil Sutter <phil@nwl.cc>
Date: Thu,  5 Jan 2017 20:09:10 +0100

> This series adds VF support to dummy device driver after adding the
> necessary infrastructure changes:
> 
> Patch 1 adds a netdevice callback for device-specific VF count
> retrieval. Patch 2 then changes dev_num_vf() implementation to make use
> of that new callback (if implemented), falling back to the old
> behaviour. Patch 3 then implements VF support in dummy, without the fake
> PCI parent device hack from v5.

Please don't make this a netdev specific method and interface.

Put the method in "struct bus_device", thereby making it a generic
"device" layer thing.

So the pci BUS type will implement pci_bus_type.num_vf().  And you'll
make a bus type for the dummy device to attach to which will implement
it's own.

  parent reply	other threads:[~2017-01-07  1:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-05 19:09 [net-next PATCH v6 0/3] net: dummy: Introduce dummy virtual functions Phil Sutter
2017-01-05 19:09 ` [net-next PATCH v6 1/3] net: net_device_ops: Introduce ndo_get_vf_count Phil Sutter
2017-01-05 19:09 ` [net-next PATCH v6 2/3] net: rtnetlink: Use a local dev_num_vf() implementation Phil Sutter
2017-01-05 19:09 ` [net-next PATCH v6 3/3] net: dummy: Introduce dummy virtual functions Phil Sutter
2017-01-07  1:38 ` David Miller [this message]
2017-01-11 13:38   ` [net-next PATCH v6 0/3] " Phil Sutter
2017-01-13 12:09     ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170106.203804.2023763441703979123.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).