From: David Miller <davem@davemloft.net>
To: g.nault@alphalink.fr
Cc: netdev@vger.kernel.org, jchapman@katalix.com, celston@katalix.com
Subject: Re: [PATCH net-next 0/4] l2tp: cleanup socket lookup code in l2tp_ip and l2tp_ip6
Date: Fri, 06 Jan 2017 22:19:13 -0500 (EST) [thread overview]
Message-ID: <20170106.221913.1150017479115532240.davem@davemloft.net> (raw)
In-Reply-To: <cover.1483727525.git.g.nault@alphalink.fr>
From: Guillaume Nault <g.nault@alphalink.fr>
Date: Fri, 6 Jan 2017 20:03:53 +0100
> First three patches remove redundant tests and add missing "const"
> qualifiers.
>
> Fourth patch splits the conditionals found in __l2tp_ip*_bind_lookup(),
> to make these functions easier to review. In the process, I found that
> some corner cases were still not handled properly. So I've added the
> missing tests in this patch too, because they're pretty simple and the
> whole "if" statements are modified anyway.
>
> I expect it to be easier to review this way. If not, I can split up
> patch #4, post the missing tests separately to -net, and later repost
> this series as pure cleanup. Just let me know.
Looks good to me, series applied, thanks.
prev parent reply other threads:[~2017-01-07 3:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 19:03 [PATCH net-next 0/4] l2tp: cleanup socket lookup code in l2tp_ip and l2tp_ip6 Guillaume Nault
2017-01-06 19:03 ` [PATCH net-next 1/4] l2tp: remove redundant addr_len check in l2tp_ip_bind() Guillaume Nault
2017-01-06 19:03 ` [PATCH net-next 2/4] l2tp: make __l2tp_ip*_bind_lookup() parameters 'const' Guillaume Nault
2017-01-06 19:03 ` [PATCH net-next 3/4] l2tp: remove useless NULL check in __l2tp_ip*_bind_lookup() Guillaume Nault
2017-01-06 19:03 ` [PATCH net-next 4/4] l2tp: rework socket comparison " Guillaume Nault
2017-01-07 3:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170106.221913.1150017479115532240.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=celston@katalix.com \
--cc=g.nault@alphalink.fr \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).