From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: michael.chan@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: Fix inconsistent rtnl_lock usage on dev_get_stats().
Date: Sat, 07 Jan 2017 21:03:24 -0500 (EST) [thread overview]
Message-ID: <20170107.210324.2205499330408276919.davem@davemloft.net> (raw)
In-Reply-To: <1483733603.9712.38.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 06 Jan 2017 12:13:23 -0800
> Well, there are cases where RTNL is quite contended, but supervisions
> like to get /proc/net/devices or various sysfs attributes
> (netstat_show() can be called very very often
> for /sys/class/net/*/statistics/*) in a reasonable amount of time.
>
> I fear that such a change will add drifts, when devices are constantly
> added/removed.
It stands to reason that RTNETLINK could use pure RCU locking for
device and stat dumps, and frankly that would make their usage and
overhead superior to poking files over and over.
prev parent reply other threads:[~2017-01-08 2:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 4:21 [PATCH net] net: Fix inconsistent rtnl_lock usage on dev_get_stats() Michael Chan
2017-01-06 11:19 ` [net] bf7d953378: BUG:sleeping_function_called_from_invalid_context_at_kernel/locking/mutex.c kernel test robot
2017-01-06 17:32 ` [PATCH net] net: Fix inconsistent rtnl_lock usage on dev_get_stats() Eric Dumazet
2017-01-06 18:01 ` David Miller
2017-01-06 19:30 ` Michael Chan
2017-01-06 20:13 ` Eric Dumazet
2017-01-08 2:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170107.210324.2205499330408276919.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).