From: Amir Vadai <amir@vadai.me>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, jiri@mellanox.com, ogerlitz@mellanox.com,
hadarh@mellanox.com
Subject: Re: [PATCH net-next V2 0/3] net/sched: act_pedit: Use offset relative to conventional network headers
Date: Sun, 8 Jan 2017 10:46:24 +0200 [thread overview]
Message-ID: <20170108084624.GA26775@office.localdomain> (raw)
In-Reply-To: <20170106.205109.917848391545129035.davem@davemloft.net>
On Fri, Jan 06, 2017 at 08:51:09PM -0500, David Miller wrote:
> From: Amir Vadai <amir@vadai.me>
> Date: Thu, 5 Jan 2017 11:54:51 +0200
>
> > Enhancing the UAPI to allow for specifying that would allow the same
> > flows to be set into both SW and HW.
>
> This is actually not backward compatible.
>
> When pedit rules are dumped, older tools will not know about the
> type field and therefore will completely misinterpret the rule.
>
> You must extend this the proper way, which is to add a new attribute
> or something along those lines. The presense of a new attribute
> is an explicit communication to older tools that somethng they
> might not support and understand is going on.
Sorry, I missed this scenario. Going back to the drawing board.
prev parent reply other threads:[~2017-01-08 8:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 9:54 [PATCH net-next V2 0/3] net/sched: act_pedit: Use offset relative to conventional network headers Amir Vadai
2017-01-05 9:54 ` [PATCH net-next V2 1/3] net/skbuff: Introduce skb_mac_offset() Amir Vadai
2017-01-05 9:54 ` [PATCH net-next V2 2/3] net/act_pedit: Support using offset relative to the conventional network headers Amir Vadai
2017-01-05 9:54 ` [PATCH net-next V2 3/3] net/act_pedit: Introduce 'add' operation Amir Vadai
2017-01-05 11:54 ` [PATCH net-next V2 0/3] net/sched: act_pedit: Use offset relative to conventional network headers Jiri Benc
2017-01-05 12:34 ` Amir Vadai
2017-01-05 12:44 ` Jiri Benc
2017-01-07 1:51 ` David Miller
2017-01-08 8:46 ` Amir Vadai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170108084624.GA26775@office.localdomain \
--to=amir@vadai.me \
--cc=davem@davemloft.net \
--cc=hadarh@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).