From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
vivien.didelot@savoirfairelinux.com
Subject: Re: [PATCH net 1/2] net: dsa: bcm_sf2: Do not clobber b53_switch_ops
Date: Sun, 8 Jan 2017 21:16:45 +0100 [thread overview]
Message-ID: <20170108201645.GE21101@lunn.ch> (raw)
In-Reply-To: <37a65faf-93f1-067a-cd85-55d96b0631cc@gmail.com>
> Agreed, and this was my initial approach, but I also wanted a minimal
> fix for David to pull into "net" while we can properly resolve this for
> "net-next" see below.
O.K, so in that case, this is fine.
> Making the ops const was my initial approach but there are several
> challenges to making it possible right now which I will address against
> net-next:
>
> - register/unregister_switch_driver actually do modify dsa_switch_ops
> while updating the list pointer, so we need to encapsulate
> dsa_switch_ops into a dsa_switch_driver plus a list member
O.K, this is dsa v1. I had v2 in mind. Yes, the list needs
abstracting.
Thanks
Andrew
next prev parent reply other threads:[~2017-01-08 20:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-08 5:01 [PATCH net 0/2] net: dsa: bcm_sf2: Couple fixes Florian Fainelli
2017-01-08 5:01 ` [PATCH net 1/2] net: dsa: bcm_sf2: Do not clobber b53_switch_ops Florian Fainelli
2017-01-08 17:41 ` Andrew Lunn
2017-01-08 19:31 ` Florian Fainelli
2017-01-08 20:16 ` Andrew Lunn [this message]
2017-01-08 20:17 ` Andrew Lunn
2017-01-08 5:01 ` [PATCH net 2/2] net: dsa: bcm_sf2: Utilize nested MDIO read/write Florian Fainelli
2017-01-08 17:41 ` Andrew Lunn
2017-01-09 3:02 ` [PATCH net 0/2] net: dsa: bcm_sf2: Couple fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170108201645.GE21101@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).