From: David Miller <davem@davemloft.net>
To: felix.manlunas@cavium.com
Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com,
derek.chickles@cavium.com, satananda.burla@cavium.com
Subject: Re: [PATCH net-next] liquidio: store the L4 hash of rx packets in skb
Date: Mon, 09 Jan 2017 13:56:21 -0500 (EST) [thread overview]
Message-ID: <20170109.135621.1633543054179916746.davem@davemloft.net> (raw)
In-Reply-To: <20170109184505.GA8756@felix.cavium.com>
From: Felix Manlunas <felix.manlunas@cavium.com>
Date: Mon, 9 Jan 2017 10:45:05 -0800
> David Miller <davem@davemloft.net> wrote on Sun [2017-Jan-08 17:09:41 -0500]:
>> From: Felix Manlunas <felix.manlunas@cavium.com>
>> Date: Fri, 6 Jan 2017 16:55:42 -0800
>>
>> >
>> > + if (rh->r_dh.has_hash) {
>> > + u32 hash = be32_to_cpu(*(u32 *)(skb->data + r_dh_off));
>>
>> Is the checksum defined to be in the first 4-bytes of the 8-byte DHLEN unit,
>> or the second 4-bytes? Is the answer to this question endian-dependent?
>
> The hash is always in the first 4-bytes. The location of the hash is endian
> independent. The hash itself (in its original form) is big endian.
Thanks for explaining.
Please fix the SPARSE issue Eric Dumazet mentioned.
next prev parent reply other threads:[~2017-01-09 18:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 0:55 [PATCH net-next] liquidio: store the L4 hash of rx packets in skb Felix Manlunas
2017-01-08 22:09 ` David Miller
2017-01-09 18:45 ` Felix Manlunas
2017-01-09 18:56 ` David Miller [this message]
2017-01-09 18:59 ` Felix Manlunas
2017-01-09 18:51 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109.135621.1633543054179916746.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=derek.chickles@cavium.com \
--cc=felix.manlunas@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@cavium.com \
--cc=satananda.burla@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).