From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH stable 4.1] openvswitch: gre: filter gre packets Date: Mon, 09 Jan 2017 14:23:06 -0500 (EST) Message-ID: <20170109.142306.2147634501831013526.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: joe@ovn.org, pshelar@ovn.org, netdev@vger.kernel.org To: uri@zoey.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:48084 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422857AbdAITXI (ORCPT ); Mon, 9 Jan 2017 14:23:08 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Uri Foox Date: Mon, 9 Jan 2017 14:20:48 -0500 > On Mon, Jan 9, 2017 at 2:07 PM, Uri Foox wrote: >> This patch was marked Not Applicable and so was >> https://patchwork.ozlabs.org/patch/559944/ which is the same thing from a >> year ago. Why are both of these not applicable? >> >> On Mon, Jan 9, 2017 at 1:48 PM, Joe Stringer wrote: >>> >>> On 8 January 2017 at 06:14, Pravin B Shelar wrote: >>> > OVS can only process L2 packets. But OVS GRE receive handler >>> > can accept IP-GRE packets. When such packet is processed by >>> > OVS datapath it can trigger following assert failure due >>> > to insufficient linear data in skb. Following patch filters >>> > received packets to avoid this issue. >>> > >>> > [68240.441681] ------------[ cut here ]------------ >>> > [68240.496918] kernel BUG at >>> > /build/linux-lts-trusty-D60X6T/linux-lts-trusty-3.13.0/include/linux/skbuff.h:1486! >>> > [68240.615520] invalid opcode: 0000 [#1] SMP >>> > [68241.953939] RIP: [] __skb_pull.part.7+0x4/0x6 >>> > [openvswitch] >>> > [68243.099945] Call Trace: >>> > [68243.129188] >>> > [68243.152204] [] ovs_flow_extract+0x664/0x720 >>> > [openvswitch] >>> > [68243.314912] [] >>> > ovs_dp_process_received_packet+0x60/0x130 [openvswitch] >>> > [68243.481559] [] ovs_vport_receive+0x2a/0x30 >>> > [openvswitch] >>> > [68243.564884] [] gre_rcv+0xa4/0xb8 [openvswitch] >>> > [68243.637802] [] gre_cisco_rcv+0x75/0xbc [gre] >>> > [68243.708621] [] gre_rcv+0x65/0x90 [gre] >>> > [68243.773214] [] ip_local_deliver_finish+0xa8/0x220 >>> > [68243.849244] [] ip_local_deliver+0x4b/0x90 >>> > [68243.916951] [] ip_rcv_finish+0x121/0x380 >>> > [68243.983627] [] ip_rcv+0x286/0x380 >>> > [68244.043023] [] >>> > __netif_receive_skb_core+0x61a/0x760 >>> > [68244.121122] [] __netif_receive_skb+0x21/0x70 >>> > [68244.191942] [] process_backlog+0xb1/0x190 >>> > [68244.259642] [] net_rx_action+0x139/0x280 >>> > [68244.326305] [] __do_softirq+0xed/0x360 >>> > [68244.390887] [] irq_exit+0x11e/0x140 >>> > [68244.452358] [] do_IRQ+0x63/0xe0 >>> > [68244.509674] [] common_interrupt+0x6d/0x6d >>> > [68245.392237] RIP [] __skb_pull.part.7+0x4/0x6 >>> > [openvswitch] >>> > [68245.520082] ---[ end trace 383bac9f3e676970 ]--- >>> > >>> > Fixes: aa310701e7 ("openvswitch: Add gre tunnel support.") >>> > Reported-by: Uri Foox >>> > CC: Joe Stringer >>> > Signed-off-by: Pravin B Shelar >>> >>> Acked-by: Joe Stringer >> > > This patch was marked Not Applicable and so was > https://patchwork.ozlabs.org/patch/559944/ which is the same thing > from a year ago. Why are both of these not applicable? This is a real > issue and has caused downtime for multiple people. I mark patches that are -stable backports at "not applicate" because they do not apply to the net or net-next tree. If you bothered to check my -stable queue on patchwork, this patch is in there.