netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Simon Horman <horms+renesas@verge.net.au>,
	netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Cc: "Geert Uytterhoeven" <geert@linux-m68k.org>,
	linux-pm@vger.kernel.org,
	"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Subject: [PATCHv3 0/6] sh_eth: add wake-on-lan support via magic packet
Date: Mon,  9 Jan 2017 16:34:03 +0100	[thread overview]
Message-ID: <20170109153409.13956-1-niklas.soderlund+renesas@ragnatech.se> (raw)

Hi,

This series adds support for Wake-on-Lan using Magic Packet for a few
models of the sh_eth driver. Patch 1/6 fix a naming error, patch 2/6 
adds generic support to control and support WoL while patches 3/6 - 6/6 
enable different models.

Based ontop of net-next master.

Changes since v2.
- Fix bookkeeping for "active_count" and "event_count" reported in 
  /sys/kernel/debug/wakeup_sources. Thanks Geert for noticing this.
- Add new patch 1/6 which corrects the name of ECMR_MPDE bit, suggested 
  by Sergei.
- s/sh7743/sh7734/ in patch 5/6. Thanks Geert for spotting this.
- Spelling improvements suggested by Sergei and Geert.
- Add Tested-by to 3/6 and 4/6.

Changes since v1.
- Split generic WoL functionality and device enablement to different
  patches.
- Enable more devices then Gen2 after feedback from Geert and
  datasheets.
- Do not set mdp->irq_enabled = false and remove specific MagicPacket
  interrupt clearing, instead let sh_eth_error() clear the interrupt as
  for other EMAC interrupts, thanks Sergei for the suggestion.
- Use the original return logic in sh_eth_resume().
- Moved sh_eth_private variable *clk to top of data structure  to avoid
  possible gaps due to alignment restrictions.
- Make wol_enabled in sh_eth_private part of the already existing
  bitfield instead of a bool.
- Do not initiate mdp->wol_enabled to 0, the struct is kzalloc'ed so
  it's already set to 0.

Niklas Söderlund (6):
  sh_eth: use correct name for ECMR_MPDE bit
  sh_eth: add generic wake-on-lan support via magic packet
  sh_eth: enable wake-on-lan for R-Car Gen2 devices
  sh_eth: enable wake-on-lan for r8a7740/armadillo
  sh_eth: enable wake-on-lan for sh7734
  sh_eth: enable wake-on-lan for sh7763

 drivers/net/ethernet/renesas/sh_eth.c | 123 +++++++++++++++++++++++++++++++---
 drivers/net/ethernet/renesas/sh_eth.h |   5 +-
 2 files changed, 117 insertions(+), 11 deletions(-)

-- 
2.11.0

             reply	other threads:[~2017-01-09 15:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09 15:34 Niklas Söderlund [this message]
2017-01-09 15:34 ` [PATCHv3 1/6] sh_eth: use correct name for ECMR_MPDE bit Niklas Söderlund
2017-01-09 15:34 ` [PATCHv3 2/6] sh_eth: add generic wake-on-lan support via magic packet Niklas Söderlund
2017-01-12 12:55   ` Sergei Shtylyov
2017-01-09 15:34 ` [PATCHv3 3/6] sh_eth: enable wake-on-lan for R-Car Gen2 devices Niklas Söderlund
2017-01-09 15:34 ` [PATCHv3 4/6] sh_eth: enable wake-on-lan for r8a7740/armadillo Niklas Söderlund
2017-01-09 15:34 ` [PATCHv3 5/6] sh_eth: enable wake-on-lan for sh7734 Niklas Söderlund
2017-01-09 15:34 ` [PATCHv3 6/6] sh_eth: enable wake-on-lan for sh7763 Niklas Söderlund
2017-01-09 20:55 ` [PATCHv3 0/6] sh_eth: add wake-on-lan support via magic packet David Miller
2017-01-09 21:48   ` Sergei Shtylyov
2017-01-09 21:55     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170109153409.13956-1-niklas.soderlund+renesas@ragnatech.se \
    --to=niklas.soderlund+renesas@ragnatech.se \
    --cc=geert@linux-m68k.org \
    --cc=horms+renesas@verge.net.au \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).