From: Stephen Hemminger <stephen@networkplumber.org>
To: Alexander Loktionov <Alexander.Loktionov@aquantia.com>
Cc: netdev@vger.kernel.org, David VomLehn <vomlehn@texas.net>,
Simon Edelhaus <Simon.Edelhaus@aquantia.com>,
Dmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>,
Pavel Belous <Pavel.Belous@aquantia.com>
Subject: Re: [PATCH v2 03/13] net: ethernet: aquantia: Add ring support code
Date: Mon, 9 Jan 2017 22:34:41 -0800 [thread overview]
Message-ID: <20170109223441.4cbca16a@xeon-e3> (raw)
In-Reply-To: <6dfadde2e1fe39b46d814c83fb7460566e860095.1483999588.git.vomlehn@texas.net>
On Mon, 9 Jan 2017 14:16:01 -0800
Alexander Loktionov <Alexander.Loktionov@aquantia.com> wrote:
> ++self->stats.rx_packets;
> + ++ndev->stats.rx_packets;
> + ndev->stats.rx_bytes += buff->len;
Why keep two sets of statistics (self->stats and ndev->stats); seems redundant.
Could also use per-cpu network stats pcpu_sw_netstats
You could also optimize by doing only one addition of ndev->stats after processing
several packets.
> + skb = netdev_alloc_skb(ndev, ETH_HLEN);
> + skb_put(skb, ETH_HLEN);
> + memcpy(skb->data, page_address(buff->page), ETH_HLEN);
Why not use build_skb() here?
next prev parent reply other threads:[~2017-01-10 6:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 22:15 [PATCH v2 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver Alexander Loktionov
2017-01-09 22:15 ` [PATCH v2 01/13] net: ethernet: aquantia: Make and configuration files Alexander Loktionov
2017-01-09 22:16 ` [PATCH v2 02/13] net: ethernet: aquantia: Common functions and definitions Alexander Loktionov
2017-01-09 22:16 ` [PATCH v2 03/13] net: ethernet: aquantia: Add ring support code Alexander Loktionov
2017-01-09 22:16 ` [PATCH v2 04/13] net: ethernet: aquantia: Low-level hardware interfaces Alexander Loktionov
2017-01-09 22:16 ` [PATCH v2 05/13] net: ethernet: aquantia: Support for NIC-specific code Alexander Loktionov
2017-01-09 22:16 ` [PATCH v2 06/13] net: ethernet: aquantia: Atlantic A0 and B0 specific functions Alexander Loktionov
2017-01-09 22:16 ` [PATCH v2 07/13] net: ethernet: aquantia: Vector operations Alexander Loktionov
2017-01-09 22:16 ` [PATCH v2 08/13] net: ethernet: aquantia: PCI operations Alexander Loktionov
2017-01-09 22:16 ` [PATCH v2 09/13] net: ethernet: aquantia: Atlantic hardware abstraction layer Alexander Loktionov
2017-01-09 22:16 ` [PATCH v2 10/13] net: ethernet: aquantia: Hardware interface and utility functions Alexander Loktionov
2017-01-09 22:16 ` [PATCH v2 11/13] net: ethernet: aquantia: Ethtool support Alexander Loktionov
2017-01-09 22:16 ` [PATCH v2 12/13] net: ethernet: aquantia: Receive side scaling Alexander Loktionov
2017-01-09 22:16 ` [PATCH v2 13/13] net: ethernet: aquantia: Integrate AQtion 2.5/5 GB NIC driver Alexander Loktionov
2017-01-10 2:52 ` kbuild test robot
2017-01-10 2:52 ` [PATCH] net: ethernet: aquantia: fix semicolon.cocci warnings kbuild test robot
2017-01-10 6:34 ` Stephen Hemminger [this message]
2017-01-11 22:05 ` [PATCH v2 01/13] net: ethernet: aquantia: Make and configuration files Rami Rosen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109223441.4cbca16a@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=Alexander.Loktionov@aquantia.com \
--cc=Dmitrii.Tarakanov@aquantia.com \
--cc=Pavel.Belous@aquantia.com \
--cc=Simon.Edelhaus@aquantia.com \
--cc=netdev@vger.kernel.org \
--cc=vomlehn@texas.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).