netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: j-keerthy@ti.com
Cc: w-kwok2@ti.com, m-karicheri2@ti.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, stephen@networkplumber.org,
	m-scherban@ti.com
Subject: Re: [PATCH] net: netcp: correct netcp_get_stats function signature
Date: Tue, 10 Jan 2017 11:52:13 -0500 (EST)	[thread overview]
Message-ID: <20170110.115213.1856085394233309828.davem@davemloft.net> (raw)
In-Reply-To: <1484047585-16733-1-git-send-email-j-keerthy@ti.com>

From: Keerthy <j-keerthy@ti.com>
Date: Tue, 10 Jan 2017 16:56:25 +0530

> @@ -1909,7 +1909,7 @@ static int netcp_setup_tc(struct net_device *dev, u32 handle, __be16 proto,
>  	return 0;
>  }
>  
> -static struct rtnl_link_stats64 *
> +void
>  netcp_get_stats(struct net_device *ndev, struct rtnl_link_stats64 *stats)

Please do not remove the static qualifier.

  reply	other threads:[~2017-01-10 16:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10 11:26 [PATCH] net: netcp: correct netcp_get_stats function signature Keerthy
2017-01-10 16:52 ` David Miller [this message]
2017-01-11  3:28   ` Keerthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170110.115213.1856085394233309828.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=j-keerthy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-karicheri2@ti.com \
    --cc=m-scherban@ti.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=w-kwok2@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).