* [PATCH net v2] mlx4: Return EOPNOTSUPP instead of ENOTSUPP
@ 2017-01-10 17:41 Martin KaFai Lau
2017-01-10 20:04 ` Saeed Mahameed
2017-01-11 2:17 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Martin KaFai Lau @ 2017-01-10 17:41 UTC (permalink / raw)
To: netdev; +Cc: Saeed Mahameed, Tariq Toukan, Kernel Team
In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs"),
it changed EOPNOTSUPP to ENOTSUPP by mistake. This patch fixes it.
Fixes: b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs")
Signed-off-by: Martin KaFai Lau <kafai@fb.com>
---
drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index edbe200ac2fa..4910d9af1933 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -2277,7 +2277,7 @@ static int mlx4_en_change_mtu(struct net_device *dev, int new_mtu)
if (priv->tx_ring_num[TX_XDP] &&
!mlx4_en_check_xdp_mtu(dev, new_mtu))
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
dev->mtu = new_mtu;
--
2.5.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net v2] mlx4: Return EOPNOTSUPP instead of ENOTSUPP
2017-01-10 17:41 [PATCH net v2] mlx4: Return EOPNOTSUPP instead of ENOTSUPP Martin KaFai Lau
@ 2017-01-10 20:04 ` Saeed Mahameed
2017-01-10 22:36 ` Martin KaFai Lau
2017-01-11 2:17 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Saeed Mahameed @ 2017-01-10 20:04 UTC (permalink / raw)
To: Martin KaFai Lau
Cc: Linux Netdev List, Saeed Mahameed, Tariq Toukan, Kernel Team
On Tue, Jan 10, 2017 at 7:41 PM, Martin KaFai Lau <kafai@fb.com> wrote:
> In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs"),
> it changed EOPNOTSUPP to ENOTSUPP by mistake. This patch fixes it.
>
> Fixes: b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs")
> Signed-off-by: Martin KaFai Lau <kafai@fb.com>
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
Thank you martin.
Small question though,
is it essential for the upper layer to get the correct errno ? or this
is just a cleanup ?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net v2] mlx4: Return EOPNOTSUPP instead of ENOTSUPP
2017-01-10 20:04 ` Saeed Mahameed
@ 2017-01-10 22:36 ` Martin KaFai Lau
0 siblings, 0 replies; 4+ messages in thread
From: Martin KaFai Lau @ 2017-01-10 22:36 UTC (permalink / raw)
To: Saeed Mahameed
Cc: Linux Netdev List, Saeed Mahameed, Tariq Toukan, Kernel Team
On Tue, Jan 10, 2017 at 10:04:55PM +0200, Saeed Mahameed wrote:
> On Tue, Jan 10, 2017 at 7:41 PM, Martin KaFai Lau <kafai@fb.com> wrote:
> > In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs"),
> > it changed EOPNOTSUPP to ENOTSUPP by mistake. This patch fixes it.
> >
> > Fixes: b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs")
> > Signed-off-by: Martin KaFai Lau <kafai@fb.com>
>
> Acked-by: Saeed Mahameed <saeedm@mellanox.com>
>
>
> Thank you martin.
>
> Small question though,
> is it essential for the upper layer to get the correct errno ? or this
> is just a cleanup ?
Former. probably for the netlink's NLMSG_ERROR also.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v2] mlx4: Return EOPNOTSUPP instead of ENOTSUPP
2017-01-10 17:41 [PATCH net v2] mlx4: Return EOPNOTSUPP instead of ENOTSUPP Martin KaFai Lau
2017-01-10 20:04 ` Saeed Mahameed
@ 2017-01-11 2:17 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2017-01-11 2:17 UTC (permalink / raw)
To: kafai; +Cc: netdev, saeedm, tariqt, kernel-team
From: Martin KaFai Lau <kafai@fb.com>
Date: Tue, 10 Jan 2017 09:41:49 -0800
> In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs"),
> it changed EOPNOTSUPP to ENOTSUPP by mistake. This patch fixes it.
>
> Fixes: b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs")
> Signed-off-by: Martin KaFai Lau <kafai@fb.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-11 2:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-10 17:41 [PATCH net v2] mlx4: Return EOPNOTSUPP instead of ENOTSUPP Martin KaFai Lau
2017-01-10 20:04 ` Saeed Mahameed
2017-01-10 22:36 ` Martin KaFai Lau
2017-01-11 2:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).