From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin KaFai Lau Subject: Re: [PATCH net-next] bpf: Make unnecessarily global functions static Date: Tue, 10 Jan 2017 16:47:00 -0800 Message-ID: <20170111004700.GA15234@kafai-mba.local> References: <20170110140216.26550-1-tklauser@distanz.ch> <20170111002222.GA68360@ast-mbp.thefacebook.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Cc: Tobias Klauser , , To: Alexei Starovoitov Return-path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:48585 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935198AbdAKArL (ORCPT ); Tue, 10 Jan 2017 19:47:11 -0500 Content-Disposition: inline In-Reply-To: <20170111002222.GA68360@ast-mbp.thefacebook.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jan 10, 2017 at 04:22:25PM -0800, Alexei Starovoitov wrote: > On Tue, Jan 10, 2017 at 03:02:16PM +0100, Tobias Klauser wrote: > > Make the functions __local_list_pop_free(), __local_list_pop_pending(), > > bpf_common_lru_populate() and bpf_percpu_lru_populate() static as they > > are not used outide of bpf_lru_list.c > > > > This fixes the following GCC warnings when building with 'W=1': > > > > kernel/bpf/bpf_lru_list.c:363:22: warning: no previous prototype for ‘__local_list_pop_free’ [-Wmissing-prototypes] > > kernel/bpf/bpf_lru_list.c:376:22: warning: no previous prototype for ‘__local_list_pop_pending’ [-Wmissing-prototypes] > > kernel/bpf/bpf_lru_list.c:560:6: warning: no previous prototype for ‘bpf_common_lru_populate’ [-Wmissing-prototypes] > > kernel/bpf/bpf_lru_list.c:577:6: warning: no previous prototype for ‘bpf_percpu_lru_populate’ [-Wmissing-prototypes] > > > > Cc: Martin KaFai Lau > > Signed-off-by: Tobias Klauser > > Acked-by: Alexei Starovoitov Thanks for the patch. Acked-by: Martin KaFai Lau