netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: next-20170110 build: 1 failures 4 warnings (next-20170110)
       [not found] <E1cQqkO-0005XB-2K@optimist>
@ 2017-01-10 18:16 ` Mark Brown
  2017-01-10 20:21   ` Stephen Rothwell
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2017-01-10 18:16 UTC (permalink / raw)
  To: Michael Scherban, Murali Karicheri, Sekhar Nori, David S. Miller
  Cc: kernel-build-reports, linaro-kernel, linux-next, linux-arm-kernel,
	netdev

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

On Tue, Jan 10, 2017 at 07:21:32AM +0000, Build bot for Mark Brown wrote:

Today's -next fails to build an arm allmodconfig due to:

> 	arm-allmodconfig
> ../drivers/net/ethernet/ti/netcp_core.c:1951:28: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]

caused by 6a8162e99ef344 (net: netcp: store network statistics in 64
bits).  It's assigning the function

  static struct rtnl_link_stats64 *
  netcp_get_stats(struct net_device *ndev, struct rtnl_link_stats64 *stats)

to ndo_get_stats64 which expects a function returning void.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: next-20170110 build: 1 failures 4 warnings (next-20170110)
  2017-01-10 18:16 ` next-20170110 build: 1 failures 4 warnings (next-20170110) Mark Brown
@ 2017-01-10 20:21   ` Stephen Rothwell
  2017-01-11 10:09     ` Sekhar Nori
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2017-01-10 20:21 UTC (permalink / raw)
  To: Mark Brown
  Cc: Michael Scherban, Murali Karicheri, Sekhar Nori, David S. Miller,
	kernel-build-reports, linaro-kernel, linux-next, linux-arm-kernel,
	netdev, stephen hemminger

Hi Mark,

On Tue, 10 Jan 2017 18:16:07 +0000 Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Jan 10, 2017 at 07:21:32AM +0000, Build bot for Mark Brown wrote:
> 
> Today's -next fails to build an arm allmodconfig due to:
> 
> > 	arm-allmodconfig
> > ../drivers/net/ethernet/ti/netcp_core.c:1951:28: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]  
> 
> caused by 6a8162e99ef344 (net: netcp: store network statistics in 64
> bits).  It's assigning the function
> 
>   static struct rtnl_link_stats64 *
>   netcp_get_stats(struct net_device *ndev, struct rtnl_link_stats64 *stats)
> 
> to ndo_get_stats64 which expects a function returning void.

Yes, but only because commit bc1f44709cf2 ("net: make ndo_get_stats64 a
void function") entered the net-next tree on the same day ... so it
needs a followup fixup patch for this new usage.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: next-20170110 build: 1 failures 4 warnings (next-20170110)
  2017-01-10 20:21   ` Stephen Rothwell
@ 2017-01-11 10:09     ` Sekhar Nori
  0 siblings, 0 replies; 3+ messages in thread
From: Sekhar Nori @ 2017-01-11 10:09 UTC (permalink / raw)
  To: Stephen Rothwell, Mark Brown
  Cc: linaro-kernel, kernel-build-reports, netdev, stephen hemminger,
	Michael Scherban, linux-next, Murali Karicheri, J, KEERTHY,
	David S. Miller, linux-arm-kernel

On Wednesday 11 January 2017 01:51 AM, Stephen Rothwell wrote:
> Hi Mark,
> 
> On Tue, 10 Jan 2017 18:16:07 +0000 Mark Brown <broonie@kernel.org> wrote:
>>
>> On Tue, Jan 10, 2017 at 07:21:32AM +0000, Build bot for Mark Brown wrote:
>>
>> Today's -next fails to build an arm allmodconfig due to:
>>
>>> 	arm-allmodconfig
>>> ../drivers/net/ethernet/ti/netcp_core.c:1951:28: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]  
>>
>> caused by 6a8162e99ef344 (net: netcp: store network statistics in 64
>> bits).  It's assigning the function
>>
>>   static struct rtnl_link_stats64 *
>>   netcp_get_stats(struct net_device *ndev, struct rtnl_link_stats64 *stats)
>>
>> to ndo_get_stats64 which expects a function returning void.
> 
> Yes, but only because commit bc1f44709cf2 ("net: make ndo_get_stats64 a
> void function") entered the net-next tree on the same day ... so it
> needs a followup fixup patch for this new usage.

Keerthy sent a patch fixing this yesterday. Looks like he will have to
spin another version though.

https://patchwork.ozlabs.org/patch/713224/

Thanks,
Sekhar

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-11 10:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1cQqkO-0005XB-2K@optimist>
2017-01-10 18:16 ` next-20170110 build: 1 failures 4 warnings (next-20170110) Mark Brown
2017-01-10 20:21   ` Stephen Rothwell
2017-01-11 10:09     ` Sekhar Nori

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).