From: Christoph Hellwig <hch@lst.de>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-pci@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@s-opensource.com>,
netdev@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 2/3] xgbe: switch to pci_irq_alloc_vectors
Date: Wed, 11 Jan 2017 10:03:57 +0100 [thread overview]
Message-ID: <20170111090357.GB7350@lst.de> (raw)
In-Reply-To: <11ed330c-84e9-79e9-7945-ca17a497359c@amd.com>
On Tue, Jan 10, 2017 at 12:40:10PM -0600, Tom Lendacky wrote:
> On 1/9/2017 2:37 PM, Christoph Hellwig wrote:
> > The newly added xgbe drivers uses the deprecated pci_enable_msi_exact
> > and pci_enable_msix_range interfaces. Switch it to use
> > pci_irq_alloc_vectors instead.
>
> I was just working on switching over to this API with some additional
> changes / simplification. I'm ok with using this patch so that you get
> the API removal accomplished. Going through the PCI tree just means
> it will probably be easier for me to hold off on the additional changes
> I wanted to make until later.
Hi Tom,
if you have a better patch I'd be more than happy to use that one instead,
this one was intended as a stupid search and replace. The important
part for me is to get the two conversions and the interface removal
in together.
E.g. I've alreayd wondered why the driver requires the exact vector
number for MSI and a variable one for MSI-X, and there certainly is
all kinds of opportunity for cosmetic cleanup.
next prev parent reply other threads:[~2017-01-11 9:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 20:37 kill off pci_enable_msi_{exact,range} Christoph Hellwig
2017-01-09 20:37 ` [PATCH 1/3] media/cobalt: use pci_irq_allocate_vectors Christoph Hellwig
2017-01-09 20:37 ` [PATCH 2/3] xgbe: switch to pci_irq_alloc_vectors Christoph Hellwig
2017-01-10 18:40 ` Tom Lendacky
2017-01-11 9:03 ` Christoph Hellwig [this message]
2017-01-11 16:46 ` Tom Lendacky
2017-01-09 20:37 ` [PATCH 3/3] PCI/msi: remove pci_enable_msi_{exact,range} Christoph Hellwig
2017-01-11 1:20 ` kill off pci_enable_msi_{exact,range} David Miller
2017-01-12 21:29 ` Bjorn Helgaas
2017-01-13 7:55 ` Christoph Hellwig
2017-01-13 8:05 ` Christoph Hellwig
2017-01-13 17:13 ` Bjorn Helgaas
2017-01-13 17:15 ` Christoph Hellwig
2017-01-13 21:28 ` Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111090357.GB7350@lst.de \
--to=hch@lst.de \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mchehab@s-opensource.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).