netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <fengguang.wu@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: kbuild-all@01.org, netdev@vger.kernel.org,
	Eric Dumazet <edumazet@google.com>
Subject: [net:master 16/18] net/core/dev.c:4444:33: note: in expansion of macro 'min'
Date: Wed, 11 Jan 2017 11:25:33 +0800	[thread overview]
Message-ID: <201701111127.P3C8aTR1%fengguang.wu@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2182 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master
head:   6c711c8691bf91d0e830ff4215b08e51c0626769
commit: 1272ce87fa017ca4cf32920764d879656b7a005a [16/18] gro: Enter slow-path if there is no tailroom
config: i386-randconfig-x004-201702 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        git checkout 1272ce87fa017ca4cf32920764d879656b7a005a
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/sched.h:17:0,
                    from include/linux/uaccess.h:4,
                    from net/core/dev.c:75:
   net/core/dev.c: In function 'skb_gro_reset_offset':
   include/linux/kernel.h:753:16: warning: comparison of distinct pointer types lacks a cast
     (void) (&min1 == &min2);   \
                   ^
   include/linux/kernel.h:756:2: note: in expansion of macro '__min'
     __min(typeof(x), typeof(y),   \
     ^~~~~
>> net/core/dev.c:4444:33: note: in expansion of macro 'min'
      NAPI_GRO_CB(skb)->frag0_len = min(skb_frag_size(frag0),
                                    ^~~

vim +/min +4444 net/core/dev.c

  4428		}
  4429	}
  4430	
  4431	static void skb_gro_reset_offset(struct sk_buff *skb)
  4432	{
  4433		const struct skb_shared_info *pinfo = skb_shinfo(skb);
  4434		const skb_frag_t *frag0 = &pinfo->frags[0];
  4435	
  4436		NAPI_GRO_CB(skb)->data_offset = 0;
  4437		NAPI_GRO_CB(skb)->frag0 = NULL;
  4438		NAPI_GRO_CB(skb)->frag0_len = 0;
  4439	
  4440		if (skb_mac_header(skb) == skb_tail_pointer(skb) &&
  4441		    pinfo->nr_frags &&
  4442		    !PageHighMem(skb_frag_page(frag0))) {
  4443			NAPI_GRO_CB(skb)->frag0 = skb_frag_address(frag0);
> 4444			NAPI_GRO_CB(skb)->frag0_len = min(skb_frag_size(frag0),
  4445							  skb->end - skb->tail);
  4446		}
  4447	}
  4448	
  4449	static void gro_pull_from_frag0(struct sk_buff *skb, int grow)
  4450	{
  4451		struct skb_shared_info *pinfo = skb_shinfo(skb);
  4452	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29102 bytes --]

                 reply	other threads:[~2017-01-11  3:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201701111127.P3C8aTR1%fengguang.wu@intel.com \
    --to=fengguang.wu@intel.com \
    --cc=edumazet@google.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kbuild-all@01.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).