* [PATCH net-next] sfc: efx_get_phys_port_id() can be static
@ 2017-01-11 16:16 Wei Yongjun
2017-01-11 21:12 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2017-01-11 16:16 UTC (permalink / raw)
To: Solarflare linux maintainers, Edward Cree, Bert Kenward
Cc: Wei Yongjun, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warning:
drivers/net/ethernet/sfc/efx.c:2337:5: warning:
symbol 'efx_get_phys_port_id' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/sfc/efx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 543fa48..f2ec853 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -2334,8 +2334,8 @@ static int efx_set_features(struct net_device *net_dev, netdev_features_t data)
return 0;
}
-int efx_get_phys_port_id(struct net_device *net_dev,
- struct netdev_phys_item_id *ppid)
+static int efx_get_phys_port_id(struct net_device *net_dev,
+ struct netdev_phys_item_id *ppid)
{
struct efx_nic *efx = netdev_priv(net_dev);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] sfc: efx_get_phys_port_id() can be static
2017-01-11 16:16 [PATCH net-next] sfc: efx_get_phys_port_id() can be static Wei Yongjun
@ 2017-01-11 21:12 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-01-11 21:12 UTC (permalink / raw)
To: weiyj.lk; +Cc: linux-net-drivers, ecree, bkenward, weiyongjun1, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Wed, 11 Jan 2017 16:16:12 +0000
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/net/ethernet/sfc/efx.c:2337:5: warning:
> symbol 'efx_get_phys_port_id' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-11 21:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-11 16:16 [PATCH net-next] sfc: efx_get_phys_port_id() can be static Wei Yongjun
2017-01-11 21:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).