* [PATCH net-next] lwt_bpf: bpf_lwt_prog_cmp() can be static
@ 2017-01-12 14:39 Wei Yongjun
2017-01-12 14:42 ` Daniel Borkmann
2017-01-12 15:05 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2017-01-12 14:39 UTC (permalink / raw)
To: David S . Miller, Thomas Graf, Alexei Starovoitov,
Daniel Borkmann
Cc: Wei Yongjun, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warning:
net/core/lwt_bpf.c:355:5: warning:
symbol 'bpf_lwt_prog_cmp' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
net/core/lwt_bpf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/lwt_bpf.c b/net/core/lwt_bpf.c
index 71bb3e2..40ef8ae 100644
--- a/net/core/lwt_bpf.c
+++ b/net/core/lwt_bpf.c
@@ -352,7 +352,7 @@ static int bpf_encap_nlsize(struct lwtunnel_state *lwtstate)
0;
}
-int bpf_lwt_prog_cmp(struct bpf_lwt_prog *a, struct bpf_lwt_prog *b)
+static int bpf_lwt_prog_cmp(struct bpf_lwt_prog *a, struct bpf_lwt_prog *b)
{
/* FIXME:
* The LWT state is currently rebuilt for delete requests which
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] lwt_bpf: bpf_lwt_prog_cmp() can be static
2017-01-12 14:39 [PATCH net-next] lwt_bpf: bpf_lwt_prog_cmp() can be static Wei Yongjun
@ 2017-01-12 14:42 ` Daniel Borkmann
2017-01-12 15:05 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2017-01-12 14:42 UTC (permalink / raw)
To: Wei Yongjun, David S . Miller, Thomas Graf, Alexei Starovoitov
Cc: Wei Yongjun, netdev
On 01/12/2017 03:39 PM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> net/core/lwt_bpf.c:355:5: warning:
> symbol 'bpf_lwt_prog_cmp' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] lwt_bpf: bpf_lwt_prog_cmp() can be static
2017-01-12 14:39 [PATCH net-next] lwt_bpf: bpf_lwt_prog_cmp() can be static Wei Yongjun
2017-01-12 14:42 ` Daniel Borkmann
@ 2017-01-12 15:05 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-01-12 15:05 UTC (permalink / raw)
To: weiyj.lk; +Cc: tgraf, ast, daniel, weiyongjun1, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Thu, 12 Jan 2017 14:39:28 +0000
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> net/core/lwt_bpf.c:355:5: warning:
> symbol 'bpf_lwt_prog_cmp' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-12 15:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-12 14:39 [PATCH net-next] lwt_bpf: bpf_lwt_prog_cmp() can be static Wei Yongjun
2017-01-12 14:42 ` Daniel Borkmann
2017-01-12 15:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).