From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: rob.gardner@oracle.com, shannon.nelson@oracle.com,
netdev@vger.kernel.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc
Date: Thu, 12 Jan 2017 15:39:29 -0500 (EST) [thread overview]
Message-ID: <20170112.153929.270105303415628819.davem@davemloft.net> (raw)
In-Reply-To: <1484252733.13165.1.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 12 Jan 2017 12:25:33 -0800
> On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote:
>
>>
>> I suspect that someplace, somebody is casting val to an int * or
>> something like that.
>
> Then that would be the bug. Can we root cause this please ?
The three accesses to foc->val are via function calls, at least when I
try to build it, one via memcmp(), one via memcpy() (for the structure
assignment at the end of the function) and one via a call into the
crypto layer when we do tcp_fastopen_cookie_gen).
So if the PC is inside of tcp_try_fastopen() it has to be something
else, or something specific to your gcc and build.
prev parent reply other threads:[~2017-01-12 20:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 19:59 [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc Shannon Nelson
2017-01-12 20:13 ` Eric Dumazet
2017-01-12 20:15 ` Rob Gardner
2017-01-12 20:25 ` Eric Dumazet
2017-01-12 20:30 ` Shannon Nelson
2017-01-12 20:41 ` David Miller
2017-01-12 20:56 ` Shannon Nelson
2017-01-12 21:18 ` David Miller
2017-01-12 21:36 ` Eric Dumazet
2017-01-12 21:47 ` David Miller
2017-01-12 21:58 ` Shannon Nelson
2017-01-12 21:58 ` David Miller
2017-01-12 20:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112.153929.270105303415628819.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rob.gardner@oracle.com \
--cc=shannon.nelson@oracle.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).