From: David Miller <davem@davemloft.net>
To: shannon.nelson@oracle.com
Cc: eric.dumazet@gmail.com, rob.gardner@oracle.com,
netdev@vger.kernel.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc
Date: Thu, 12 Jan 2017 16:18:52 -0500 (EST) [thread overview]
Message-ID: <20170112.161852.1469407145449781531.davem@davemloft.net> (raw)
In-Reply-To: <131ec7b7-5b74-2545-8bf7-92812443a876@oracle.com>
From: Shannon Nelson <shannon.nelson@oracle.com>
Date: Thu, 12 Jan 2017 12:56:08 -0800
>
>
> On 1/12/2017 12:41 PM, David Miller wrote:
>> From: Shannon Nelson <shannon.nelson@oracle.com>
>> Date: Thu, 12 Jan 2017 12:30:38 -0800
>>
>>> On 1/12/2017 12:25 PM, Eric Dumazet wrote:
>>>> On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote:
>>>>
>>>>>
>>>>> I suspect that someplace, somebody is casting val to an int * or
>>>>> something like that.
>>>>
>>>> Then that would be the bug. Can we root cause this please ?
>>>>
>>>>
>>>
>>> Look in net/ipv4/tcp_fastopen.c:tcp_fastopen_cookie_gen() for the line
>>>
>>> struct in6_addr *buf = (struct in6_addr *) tmp.val;
>>
>> Oh yeah, that's it. I didn't notice that at all.
>>
>
> It looked to me like swapping the data fields would be the easiest and
> least impactive way to fix this. I didn't want to mess with the
> logic. I'm certainly open to other suggestions.
Given the nature of the problem, your fix is probably fine.
Eric, any objections?
next prev parent reply other threads:[~2017-01-12 21:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 19:59 [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc Shannon Nelson
2017-01-12 20:13 ` Eric Dumazet
2017-01-12 20:15 ` Rob Gardner
2017-01-12 20:25 ` Eric Dumazet
2017-01-12 20:30 ` Shannon Nelson
2017-01-12 20:41 ` David Miller
2017-01-12 20:56 ` Shannon Nelson
2017-01-12 21:18 ` David Miller [this message]
2017-01-12 21:36 ` Eric Dumazet
2017-01-12 21:47 ` David Miller
2017-01-12 21:58 ` Shannon Nelson
2017-01-12 21:58 ` David Miller
2017-01-12 20:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112.161852.1469407145449781531.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rob.gardner@oracle.com \
--cc=shannon.nelson@oracle.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).