From: Andrew Lunn <andrew@lunn.ch>
To: "Kwok, WingMan" <w-kwok2@ti.com>
Cc: "rmk+kernel@arm.linux.org.uk" <rmk+kernel@arm.linux.org.uk>,
"Karicheri, Muralidharan" <m-karicheri2@ti.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: Marvell Phy (1510) issue since v4.7 kernel
Date: Thu, 12 Jan 2017 02:06:58 +0100 [thread overview]
Message-ID: <20170112010658.GA25391@lunn.ch> (raw)
In-Reply-To: <230CBA6E4B6B6B418E8730AC28E6FC7E15354B66@DFLE11.ent.ti.com>
> Hi Andrew,
>
> I double checked that ours is actually a 88E1514. According
> to Marvell's brief description, it seems that it does support
> fiber.
>
> Reading page 18 reg 30 returns 6.
O.K, that is consistent. Looking at the Marvell SDK:
phy/Include/madApiDefs.h:#define MAD_SUB_88E1510 4 /* 88E1510 */
phy/Include/madApiDefs.h:#define MAD_SUB_88E1518 5 /* 88E1518 */
phy/Include/madApiDefs.h:#define MAD_SUB_88E1512 6 /* 88E1512/88E1514 */
I took another look at the patch adding Fibre support. The
suspend/resume functions are wrong.
/* Suspend the fiber mode first */
if (!(phydev->supported & SUPPORTED_FIBRE)) {
The ! should not be there. Does removing them both fix your problem?
Andrew
next prev parent reply other threads:[~2017-01-12 1:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 22:38 Marvell Phy (1510) issue since v4.7 kernel Murali Karicheri
2017-01-09 22:56 ` Andrew Lunn
2017-01-09 23:48 ` Kwok, WingMan
2017-01-09 23:55 ` Andrew Lunn
2017-01-10 1:37 ` Kwok, WingMan
2017-01-10 1:53 ` Andrew Lunn
2017-01-11 22:18 ` Kwok, WingMan
2017-01-11 22:27 ` Andrew Lunn
2017-01-11 22:32 ` Kwok, WingMan
2017-01-11 22:41 ` Kwok, WingMan
2017-01-11 22:59 ` Andrew Lunn
2017-01-11 23:09 ` Kwok, WingMan
2017-01-11 23:22 ` Andrew Lunn
2017-01-12 0:31 ` Kwok, WingMan
2017-01-12 1:06 ` Andrew Lunn [this message]
2017-01-12 21:31 ` Kwok, WingMan
2017-01-12 21:41 ` Russell King - ARM Linux
2017-01-12 22:40 ` Kwok, WingMan
2017-01-12 21:49 ` Andrew Lunn
2017-01-12 22:31 ` Russell King - ARM Linux
2017-01-12 22:49 ` Kwok, WingMan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112010658.GA25391@lunn.ch \
--to=andrew@lunn.ch \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=w-kwok2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).