From: Ursula Braun <ubraun@linux.vnet.ibm.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
ubraun@linux.vnet.ibm.com
Subject: [PATCH RESEND net-next 03/12] s390/qeth: display warning for OSA3 RX/TX checksum offloading
Date: Thu, 12 Jan 2017 15:48:34 +0100 [thread overview]
Message-ID: <20170112144843.33463-4-ubraun@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170112144843.33463-1-ubraun@linux.vnet.ibm.com>
From: Thomas Richter <tmricht@linux.vnet.ibm.com>
When RX/TX checksum offloading is turned on and the adapter is
an OSA 3 card in layer 3 mode, the checksum offloading is only
performed when both peers use different adapters. If both peers
share an OSA 3 card, communication is a memory copy and
checksum offloading is not performed.
This patch adds a warning to inform the administrator.
OSA 3 in layer 2 mode does not offer the RX/TX checksum
offload feature.
Signed-off-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
Reviewed-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>
Reviewed-by: Ursula Braun <ubraun@linux.vnet.ibm.com>
---
drivers/s390/net/qeth_core_main.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
index 49b813f..ca8309f 100644
--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers/s390/net/qeth_core_main.c
@@ -6116,6 +6116,11 @@ static int qeth_send_checksum_on(struct qeth_card *card, int cstype)
if ((required_features & chksum_cb.supported) !=
required_features)
rc = -EIO;
+ else if (!(QETH_IPA_CHECKSUM_LP2LP & chksum_cb.supported) &&
+ cstype == IPA_INBOUND_CHECKSUM)
+ dev_warn(&card->gdev->dev,
+ "Hardware checksumming is performed only if %s and its peer use different OSA Express 3 ports\n",
+ QETH_CARD_IFNAME(card));
}
if (rc) {
qeth_send_simple_setassparms(card, cstype, IPA_CMD_ASS_STOP, 0);
--
2.8.4
next prev parent reply other threads:[~2017-01-12 14:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 14:48 [PATCH RESEND net-next 00/12] s390: qeth patches Ursula Braun
2017-01-12 14:48 ` [PATCH RESEND net-next 01/12] s390/qeth: rework RX/TX checksum offload Ursula Braun
2017-01-12 14:48 ` [PATCH RESEND net-next 02/12] s390/qeth: test RX/TX checksum offload reply Ursula Braun
2017-01-12 14:48 ` Ursula Braun [this message]
2017-01-12 14:48 ` [PATCH RESEND net-next 04/12] s390/qeth: Allow reading hsuid in state DOWN Ursula Braun
2017-01-12 14:48 ` [PATCH RESEND net-next 05/12] s390/qeth: Remove QETH_IP_HEADER_SIZE Ursula Braun
2017-01-12 14:48 ` [PATCH RESEND net-next 06/12] s390/qeth: drop qeth_l2_del_all_macs() parameter Ursula Braun
2017-01-12 14:48 ` [PATCH RESEND net-next 07/12] s390/qeth: don't convert return code twice Ursula Braun
2017-01-12 14:48 ` [PATCH RESEND net-next 08/12] s390/qeth: consolidate errno translation Ursula Braun
2017-01-12 14:48 ` [PATCH RESEND net-next 09/12] s390/qeth: extract qeth_l2_remove_mac() Ursula Braun
2017-01-12 14:48 ` [PATCH RESEND net-next 10/12] s390/qeth: shuffle MAC management functions around Ursula Braun
2017-01-12 14:48 ` [PATCH RESEND net-next 11/12] s390/qeth: issue STARTLAN as first IPA command Ursula Braun
2017-01-12 14:48 ` [PATCH RESEND net-next 12/12] s390/qeth: fix retrieval of vipa and proxy-arp addresses Ursula Braun
2017-01-12 15:03 ` [PATCH RESEND net-next 00/12] s390: qeth patches David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112144843.33463-4-ubraun@linux.vnet.ibm.com \
--to=ubraun@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).