netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Colin Cross <ccross@android.com>,
	Hariprasad S <hariprasad@chelsio.com>,
	Santosh Raspatur <santosh@chelsio.com>,
	Kees Cook <keescook@chromium.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Anton Vorontsov <anton@enomsg.org>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Ilya Dryomov <idryomov@gmail.com>,
	Kent Overstreet <kent.overstreet@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	David Rientjes <rientjes@google.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Oleg Drokin <oleg.drokin@intel.com>,
	Tony Luck <tony.luck@intel.com>,
	Alexei Starovoitov <ast@kernel.org>,
	linux-mm@kvack.org, Tariq Toukan <tariqt@mellanox.com>,
	Yishai Hadas <yishaih@mellanox.com>,
	Boris Ostrovsky <boris.ostrovsky@oracl
Subject: Re: [PATCH 5/6] treewide: use kv[mz]alloc* rather than opencoded variants
Date: Thu, 12 Jan 2017 16:57:43 +0100	[thread overview]
Message-ID: <20170112155743.GN12081@suse.cz> (raw)
In-Reply-To: <20170112153717.28943-6-mhocko@kernel.org>

On Thu, Jan 12, 2017 at 04:37:16PM +0100, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
> 
> There are many code paths opencoding kvmalloc. Let's use the helper
> instead. The main difference to kvmalloc is that those users are usually
> not considering all the aspects of the memory allocator. E.g. allocation
> requests < 64kB are basically never failing and invoke OOM killer to
> satisfy the allocation. This sounds too disruptive for something that
> has a reasonable fallback - the vmalloc. On the other hand those
> requests might fallback to vmalloc even when the memory allocator would
> succeed after several more reclaim/compaction attempts previously. There
> is no guarantee something like that happens though.
> 
> This patch converts many of those places to kv[mz]alloc* helpers because
> they are more conservative.

For the btrfs bits,

Acked-by: David Sterba <dsterba@suse.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-01-12 15:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170112153717.28943-1-mhocko@kernel.org>
2017-01-12 15:37 ` [PATCH 5/6] treewide: use kv[mz]alloc* rather than opencoded variants Michal Hocko
2017-01-12 15:57   ` David Sterba [this message]
2017-01-12 16:05   ` Christian Borntraeger
2017-01-12 16:54   ` Ilya Dryomov
2017-01-12 17:18     ` Michal Hocko
2017-01-12 17:00   ` Dan Williams
2017-01-12 17:26   ` Kees Cook
2017-01-12 17:37     ` Michal Hocko
2017-01-20 13:41       ` Vlastimil Babka
2017-01-24 15:00         ` Michal Hocko
2017-01-25 11:15           ` Vlastimil Babka
2017-01-25 13:09             ` Michal Hocko
2017-01-25 13:40               ` Ilya Dryomov
2017-01-12 17:29   ` Michal Hocko
2017-01-12 20:14   ` Boris Ostrovsky
2017-01-13  1:11   ` Dilger, Andreas
2017-01-14 10:56   ` Leon Romanovsky
2017-01-16  7:33     ` Michal Hocko
2017-01-16  8:28       ` Leon Romanovsky
2017-01-16  8:18   ` Tariq Toukan
2017-01-12 15:37 ` [RFC PATCH 6/6] net: use kvmalloc with __GFP_REPEAT rather than open coded variant Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170112155743.GN12081@suse.cz \
    --to=dsterba@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=andreas.dilger@intel.com \
    --cc=anton@enomsg.org \
    --cc=ast@kernel.org \
    --cc=boris.ostrovsky@oracl \
    --cc=ccross@android.com \
    --cc=dan.j.williams@intel.com \
    --cc=eric.dumazet@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=hariprasad@chelsio.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=idryomov@gmail.com \
    --cc=keescook@chromium.org \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=oleg.drokin@intel.com \
    --cc=rientjes@google.com \
    --cc=santosh@chelsio.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=tariqt@mellanox.com \
    --cc=tony.luck@intel.com \
    --cc=yishaih@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).