From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, frank.kellermann@atos.net
Subject: Re: [PATCH iproute2] rttable: Fix invalid range checking when table id is converted to u32
Date: Thu, 12 Jan 2017 17:36:21 -0800 [thread overview]
Message-ID: <20170112173621.1d124bb4@xeon-e3> (raw)
In-Reply-To: <1484091235-17749-1-git-send-email-dsa@cumulusnetworks.com>
On Tue, 10 Jan 2017 15:33:55 -0800
David Ahern <dsa@cumulusnetworks.com> wrote:
> Frank reported that table ids for very large numbers are not properly
> detected:
> $ ip li add foobar type vrf table 98765432100123456789
>
> command succeeds and resulting table id is actually:
>
> 21: foobar: <NOARP,MASTER> mtu 65536 qdisc noop state DOWN mode DEFAULT group default qlen 1000
> link/ether da:ea:d4:77:38:2a brd ff:ff:ff:ff:ff:ff promiscuity 0
> vrf table 4294967295 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
>
> Make the temp variable 'i' unsigned long and let the typecast to u32
> happen on assignment to id.
>
> Reported-by: Frank Kellermann <frank.kellermann@atos.net>
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Applied thanks.
prev parent reply other threads:[~2017-01-13 1:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 23:33 [PATCH iproute2] rttable: Fix invalid range checking when table id is converted to u32 David Ahern
2017-01-13 1:36 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112173621.1d124bb4@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsa@cumulusnetworks.com \
--cc=frank.kellermann@atos.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).