From: Stephen Hemminger <stephen@networkplumber.org>
To: Nogah Frankel <nogahf@mellanox.com>
Cc: netdev@vger.kernel.org, roszenrami@gmail.com,
roopa@cumulusnetworks.com, jiri@mellanox.com,
idosch@mellanox.com, eladr@mellanox.com, yotamg@mellanox.com,
ogerlitz@mellanox.com
Subject: Re: [PATCH iproute2 v4 3/4] ifstat: Add 64 bits based stats to extended statistics
Date: Thu, 12 Jan 2017 17:43:35 -0800 [thread overview]
Message-ID: <20170112174335.1bd391c2@xeon-e3> (raw)
In-Reply-To: <1484228991-32999-4-git-send-email-nogahf@mellanox.com>
On Thu, 12 Jan 2017 15:49:50 +0200
Nogah Frankel <nogahf@mellanox.com> wrote:
> The default stats for ifstat are 32 bits based.
> The kernel supports 64 bits based stats. (They are returned in struct
> rtnl_link_stats64 which is an exact copy of struct rtnl_link_stats, in
> which the "normal" stats are returned, but with fields of u64 instead of
> u32). This patch adds them as an extended stats.
>
> It is read with filter type IFLA_STATS_LINK_64 and no sub type.
>
> It is under the name 64bits
> (or any shorten of it as "64")
>
> For example:
> ifstat -x 64bit
>
> Signed-off-by: Nogah Frankel <nogahf@mellanox.com>
> Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Other commands (like ip link) always use the 64 bit statistics if available
from the device. I see no reason that ifstat needs to be different.
next prev parent reply other threads:[~2017-01-13 1:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 13:49 [PATCH iproute2 v4 0/4] update ifstat for new stats Nogah Frankel
2017-01-12 13:49 ` [PATCH iproute2 v4 1/4] ifstat: Includes reorder Nogah Frankel
2017-01-13 10:10 ` Sergei Shtylyov
2017-01-15 13:49 ` Nogah Frankel
2017-01-12 13:49 ` [PATCH iproute2 v4 2/4] ifstat: Add extended statistics to ifstat Nogah Frankel
2017-01-12 13:49 ` [PATCH iproute2 v4 3/4] ifstat: Add 64 bits based stats to extended statistics Nogah Frankel
2017-01-13 1:43 ` Stephen Hemminger [this message]
2017-01-15 13:54 ` Nogah Frankel
2017-01-19 15:21 ` Nogah Frankel
2017-01-19 16:06 ` Roopa Prabhu
2017-01-19 19:11 ` Stephen Hemminger
2017-01-22 15:34 ` Nogah Frankel
2017-01-12 13:49 ` [PATCH iproute2 v4 4/4] ifstat: Add "sw only" extended statistics to ifstat Nogah Frankel
2017-01-12 15:32 ` [PATCH iproute2 v4 0/4] update ifstat for new stats Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112174335.1bd391c2@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nogahf@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=roszenrami@gmail.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).