From: Jiri Benc <jbenc@redhat.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
mrv@mojatatu.com, cdillaba@mojatatu.com, lucasb@mojatatu.com
Subject: Re: [PATCH v2 iproute2 9/9] man pages: add man page for skbmod action
Date: Fri, 13 Jan 2017 11:01:08 +0100 [thread overview]
Message-ID: <20170113110108.19f8bffd@griffin> (raw)
In-Reply-To: <1476183648-25850-10-git-send-email-jhs@emojatatu.com>
On Tue, 11 Oct 2016 07:00:48 -0400, Jamal Hadi Salim wrote:
> From: Lucas Bates <lucasb@mojatatu.com>
>
> Signed-off-by: Lucas Bates <lucasb@mojatatu.com>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
> ---
> man/man8/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man/man8/Makefile b/man/man8/Makefile
> index 4ad96ce..de6f249 100644
> --- a/man/man8/Makefile
> +++ b/man/man8/Makefile
> @@ -16,7 +16,7 @@ MAN8PAGES = $(TARGETS) ip.8 arpd.8 lnstat.8 routel.8 rtacct.8 rtmon.8 rtpr.8 ss.
> tc-basic.8 tc-cgroup.8 tc-flow.8 tc-flower.8 tc-fw.8 tc-route.8 \
> tc-tcindex.8 tc-u32.8 tc-matchall.8 \
> tc-connmark.8 tc-csum.8 tc-mirred.8 tc-nat.8 tc-pedit.8 tc-police.8 \
> - tc-simple.8 tc-skbedit.8 tc-vlan.8 tc-xt.8 tc-ife.8 \
> + tc-simple.8 tc-skbedit.8 tc-vlan.8 tc-xt.8 tc-ife.8 tc-skbmod.8 \
> devlink.8 devlink-dev.8 devlink-monitor.8 devlink-port.8 devlink-sb.8
>
> all: $(TARGETS)
Seems that nobody really installs iproute2 :-)
The patch is missing the actual tc-skbmod.8 file which causes 'make
install' to fail:
install -m 0755 -d /tmp/ip/usr/share/man/man8
install -m 0644 ip-address.8 ip-link.8 ip-route.8 ip.8 arpd.8 lnstat.8 routel.8 rtacct.8 rtmon.8 rtpr.8 ss.8 tc.8 tc-bfifo.8 tc-bpf.8 tc-cbq.8 tc-cbq-details.8 tc-choke.8 tc-codel.8 tc-fq.8 tc-drr.8 tc-ematch.8 tc-fq_codel.8 tc-hfsc.8 tc-htb.8 tc-pie.8 tc-mqprio.8 tc-netem.8 tc-pfifo.8 tc-pfifo_fast.8 tc-prio.8 tc-red.8 tc-sfb.8 tc-sfq.8 tc-stab.8 tc-tbf.8 bridge.8 rtstat.8 ctstat.8 nstat.8 routef.8 ip-addrlabel.8 ip-fou.8 ip-gue.8 ip-l2tp.8 ip-macsec.8 ip-maddress.8 ip-monitor.8 ip-mroute.8 ip-neighbour.8 ip-netns.8 ip-ntable.8 ip-rule.8 ip-tunnel.8 ip-xfrm.8 ip-tcp_metrics.8 ip-netconf.8 ip-token.8 tipc.8 tipc-bearer.8 tipc-link.8 tipc-media.8 tipc-nametable.8 tipc-node.8 tipc-socket.8 tc-basic.8 tc-cgroup.8 tc-flow.8 tc-flower.8 tc-fw.8 tc-route.8 tc-tcindex.8 tc-u32.8 tc-matchall.8 tc-
connmark.8 tc-csum.8 tc-mirred.8 tc-nat.8 tc-pedit.8 tc-police.8 tc-simple.8 tc-skbedit.8 tc-vlan.8 tc-xt.8 tc-ife.8 tc-skbmod.8 tc-tunnel_key.8 devlink.8 devlink-dev.8 devlink-monitor.8 devlink-port.8 devlink-sb.8 /tmp/ip/usr/share/man/man8
install: cannot stat ‘tc-skbmod.8’: No such file or directory
make[2]: *** [install] Error 1
make[1]: *** [install] Error 2
Stephen, please revert commit a40995d1c79e5.
Jiri
next prev parent reply other threads:[~2017-01-13 10:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 11:00 [PATCH v2 iproute2 0/9] Cleanup backlog Jamal Hadi Salim
2016-10-11 11:00 ` [PATCH v2 iproute2 1/9] ife action: allow specifying index in hex Jamal Hadi Salim
2016-10-11 11:00 ` [PATCH v2 iproute2 2/9] ife: print prio, mark and hash as unsigned Jamal Hadi Salim
2016-10-11 11:00 ` [PATCH v2 iproute2 3/9] ife: improve help text Jamal Hadi Salim
2016-10-11 11:00 ` [PATCH v2 iproute2 4/9] actions ife: Introduce encoding and decoding of tcindex metadata Jamal Hadi Salim
2016-10-11 11:00 ` [PATCH v2 iproute2 5/9] action gact: list pipe as a valid action Jamal Hadi Salim
2016-10-11 11:00 ` [PATCH v2 iproute2 6/9] actions: add skbmod action Jamal Hadi Salim
2016-10-11 11:00 ` [PATCH v2 iproute2 7/9] man pages: update ife action to include tcindex Jamal Hadi Salim
2016-10-11 11:00 ` [PATCH v2 iproute2 8/9] man pages: Add tc-ife to Makefile Jamal Hadi Salim
2016-10-11 11:00 ` [PATCH v2 iproute2 9/9] man pages: add man page for skbmod action Jamal Hadi Salim
2017-01-13 10:01 ` Jiri Benc [this message]
2016-10-12 22:26 ` [PATCH v2 iproute2 0/9] Cleanup backlog Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113110108.19f8bffd@griffin \
--to=jbenc@redhat.com \
--cc=cdillaba@mojatatu.com \
--cc=jhs@mojatatu.com \
--cc=lucasb@mojatatu.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox