From: Tobias Klauser <tklauser@distanz.ch>
To: Shyam Saini <mayhs11saini@gmail.com>
Cc: hariprasad@chelsio.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cxgb4: Remove redundant memset before memcpy
Date: Fri, 13 Jan 2017 16:57:14 +0100 [thread overview]
Message-ID: <20170113155714.GE1201@distanz.ch> (raw)
In-Reply-To: <1484301169-11724-1-git-send-email-mayhs11saini@gmail.com>
On 2017-01-13 at 10:52:49 +0100, Shyam Saini <mayhs11saini@gmail.com> wrote:
> The region set by the call to memset, immediately overwritten by the
> subsequent call to memcpy and thus makes the memset redundant
>
> Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
> ---
> drivers/net/ethernet/chelsio/cxgb4/sched.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c b/drivers/net/ethernet/chelsio/cxgb4/sched.c
> index cbd68a8..5725693 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/sched.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/sched.c
> @@ -398,7 +398,6 @@ static struct sched_class *t4_sched_class_lookup(struct port_info *pi,
> struct ch_sched_params tp;
>
> memset(&info, 0, sizeof(info));
This memset is also redundant because info is memcpy()'ed to before
being used in the loop (and it isn't used outside of the loop).
> - memset(&tp, 0, sizeof(tp));
>
> memcpy(&tp, p, sizeof(tp));
> /* Don't try to match class parameter */
> @@ -409,7 +408,6 @@ static struct sched_class *t4_sched_class_lookup(struct port_info *pi,
> if (e->state == SCHED_STATE_UNUSED)
> continue;
>
> - memset(&info, 0, sizeof(info));
> memcpy(&info, &e->info, sizeof(info));
> /* Don't try to match class parameter */
> info.u.params.class = SCHED_CLS_NONE;
> @@ -458,7 +456,6 @@ static struct sched_class *t4_sched_class_alloc(struct port_info *pi,
> if (!e)
> goto out;
>
> - memset(&np, 0, sizeof(np));
> memcpy(&np, p, sizeof(np));
> np.u.params.class = e->idx;
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-01-13 15:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 9:52 [PATCH] cxgb4: Remove redundant memset before memcpy Shyam Saini
2017-01-13 15:57 ` Tobias Klauser [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-01-14 1:17 Shyam Saini
2017-01-14 12:27 ` Tobias Klauser
2017-01-14 17:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113155714.GE1201@distanz.ch \
--to=tklauser@distanz.ch \
--cc=hariprasad@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mayhs11saini@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).