From: Andrew Lunn <andrew@lunn.ch>
To: Volodymyr Bendiuga <volodymyr.bendiuga@gmail.com>
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org,
volodymyr.bendiuga@westermo.se,
"Magnus Öberg" <magnus.oberg@westermo.se>
Subject: Re: [PATCH net-next] mii_bus: increase MII_BUS_ID_SIZE to 61
Date: Fri, 13 Jan 2017 17:31:08 +0100 [thread overview]
Message-ID: <20170113163108.GN10203@lunn.ch> (raw)
In-Reply-To: <1484320752-32096-1-git-send-email-volodymyr.bendiuga@gmail.com>
On Fri, Jan 13, 2017 at 04:19:12PM +0100, Volodymyr Bendiuga wrote:
> From: Volodymyr Bendiuga <volodymyr.bendiuga@westermo.se>
>
> Some bus names are pretty long and do not fit into 20 chars.
>
> Signed-off-by: Volodymyr Bendiuga <volodymyr.bendiuga@westermo.se>
> Signed-off-by: Magnus Öberg <magnus.oberg@westermo.se>
> ---
> include/linux/phy.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index feb8a98..b67f94d 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -162,7 +162,7 @@ static inline const char *phy_modes(phy_interface_t interface)
> * Need to be a little smaller than phydev->dev.bus_id to leave room
> * for the ":%02x"
> */
> -#define MII_BUS_ID_SIZE (20 - 3)
> +#define MII_BUS_ID_SIZE (64 - 3)
Hi Volodymyr
Humm, i assume you looked at the comment? What is the size of phydev->dev.bus_id?
Is 61 still a little smaller?
Andrew
next prev parent reply other threads:[~2017-01-13 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 15:19 [PATCH net-next] mii_bus: increase MII_BUS_ID_SIZE to 61 Volodymyr Bendiuga
2017-01-13 16:31 ` Andrew Lunn [this message]
2017-01-13 18:59 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113163108.GN10203@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=magnus.oberg@westermo.se \
--cc=netdev@vger.kernel.org \
--cc=volodymyr.bendiuga@gmail.com \
--cc=volodymyr.bendiuga@westermo.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).