From: David Miller <davem@davemloft.net>
To: ttoukan.linux@gmail.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
erezsh@mellanox.com, eugenia@mellanox.com, tariqt@mellanox.com
Subject: Re: [PATCH net] mlx4: do not call napi_schedule() without care
Date: Mon, 16 Jan 2017 11:45:06 -0500 (EST) [thread overview]
Message-ID: <20170116.114506.889699414533682932.davem@davemloft.net> (raw)
In-Reply-To: <352911f4-7073-ad7f-83d9-dbcc6e07d553@gmail.com>
From: Tariq Toukan <ttoukan.linux@gmail.com>
Date: Mon, 16 Jan 2017 11:02:44 +0200
> Thanks Eric.
>
> On 13/01/2017 6:39 PM, Eric Dumazet wrote:
>> From: Eric Dumazet <edumazet@google.com>
>>
>> Disable BH around the call to napi_schedule() to avoid following
>> warning
>>
>> [ 52.095499] NOHZ: local_softirq_pending 08
>> [ 52.421291] NOHZ: local_softirq_pending 08
>> [ 52.608313] NOHZ: local_softirq_pending 08
>>
>> Fixes: 8d59de8f7bb3 ("net/mlx4_en: Process all completions in RX rings
>> after port goes up")
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
...
> Acked-by: Tariq Toukan <tariqt@mellanox.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2017-01-16 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 16:39 [PATCH net] mlx4: do not call napi_schedule() without care Eric Dumazet
2017-01-13 23:07 ` Alexander Duyck
2017-01-13 23:40 ` Eric Dumazet
2017-01-16 9:02 ` Tariq Toukan
2017-01-16 16:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116.114506.889699414533682932.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=erezsh@mellanox.com \
--cc=eric.dumazet@gmail.com \
--cc=eugenia@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).