netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: Yuval.Mintz@cavium.com
Cc: mayhs11saini@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr
Date: Mon, 16 Jan 2017 12:12:03 -0500 (EST)	[thread overview]
Message-ID: <20170116.121203.1376051612147199138.davem@davemloft.net> (raw)
In-Reply-To: <BL2PR07MB23069F2EFE839087FF63AC488D7D0@BL2PR07MB2306.namprd07.prod.outlook.com>

From: "Mintz, Yuval" <Yuval.Mintz@cavium.com>
Date: Mon, 16 Jan 2017 17:05:05 +0000

> Other than the fact these 2 patches change 2 different qed files,

That's what I was trying to hint at, the locations within the drivers
were the unique element.

> is there any significant difference between what each does?
> If not, why not simply do both in a single patch?

Also agreed.

  reply	other threads:[~2017-01-16 17:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-16  3:44 [PATCH 1/2] qed: Replace memset with eth_zero_addr Shyam Saini
2017-01-16  3:44 ` [PATCH 2/2] " Shyam Saini
2017-01-16  4:38 ` [PATCH 1/2] " David Miller
2017-01-16  9:24   ` Shyam Saini
2017-01-16 16:46     ` David Miller
2017-01-16 17:05       ` Mintz, Yuval
2017-01-16 17:12         ` David Miller [this message]
2017-01-16 17:40       ` Shyam Saini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170116.121203.1376051612147199138.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Yuval.Mintz@cavium.com \
    --cc=mayhs11saini@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).