From: David Miller <davem@davemloft.net>
To: mahesh@bandewar.net
Cc: netdev@vger.kernel.org, maheshb@google.com, davem@davemloft.org,
edumazet@google.com
Subject: Re: [PATCH next] ipvlan: fix dev_id creation corner case.
Date: Mon, 16 Jan 2017 14:05:14 -0500 (EST) [thread overview]
Message-ID: <20170116.140514.1674761589594644492.davem@davemloft.net> (raw)
In-Reply-To: <20170113234830.16054-1-mahesh@bandewar.net>
From: Mahesh Bandewar <mahesh@bandewar.net>
Date: Fri, 13 Jan 2017 15:48:30 -0800
> From: Mahesh Bandewar <maheshb@google.com>
>
> In the last patch da36e13cf65 ("ipvlan: improvise dev_id generation
> logic in IPvlan") I missed some part of Dave's suggestion and because
> of that the dev_id creation could fail in a corner case scenario. This
> would happen when more or less 64k devices have been already created and
> several have been deleted. If the devices that are still sticking around
> are the last n bits from the bitmap. So in this scenario even if lower
> bits are available, the dev_id search is so narrow that it always fails.
>
> Fixes: da36e13cf65 ("ipvlan: improvise dev_id generation logic in IPvlan")
> CC: David Miller <davem@davemloft.org>
> CC: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied, thanks.
prev parent reply other threads:[~2017-01-16 19:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 23:48 [PATCH next] ipvlan: fix dev_id creation corner case Mahesh Bandewar
2017-01-16 19:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116.140514.1674761589594644492.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davem@davemloft.org \
--cc=edumazet@google.com \
--cc=mahesh@bandewar.net \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).