netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shyam Saini <mayhs11saini@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: Yuval.Mintz@cavium.com, Ariel.Elior@cavium.com,
	everest-linux-l2@cavium.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr
Date: Mon, 16 Jan 2017 14:54:35 +0530	[thread overview]
Message-ID: <20170116092435.GA2970@mystictot> (raw)
In-Reply-To: <20170115.233830.123911280062970298.davem@davemloft.net>

On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote:
> 
> Please do not ever submit two patches which have the same exact commit
> header line, as these two patches do.
> 
> When someone looks into the shortlog of GIT history all they will see
> is "qed: Replace memset with eth_zero_addr" twice.
> 
> This gives the reader no idea what might be different between those
> two changes.
> 
> Therefore you must give unique a commit header text for each change,
> which communicates sufficiently what is different in each change.

Thanks a lot for correcting me. I'll take care of this thing.

I'm resending these two patches as 
	1). qed: Replace memset with eth_zero_addr
	2). qed: Use eth_zero_addr
	
I hope it resolves same commit header line conflict.

Regards,
Shyam

  reply	other threads:[~2017-01-16  9:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-16  3:44 [PATCH 1/2] qed: Replace memset with eth_zero_addr Shyam Saini
2017-01-16  3:44 ` [PATCH 2/2] " Shyam Saini
2017-01-16  4:38 ` [PATCH 1/2] " David Miller
2017-01-16  9:24   ` Shyam Saini [this message]
2017-01-16 16:46     ` David Miller
2017-01-16 17:05       ` Mintz, Yuval
2017-01-16 17:12         ` David Miller
2017-01-16 17:40       ` Shyam Saini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170116092435.GA2970@mystictot \
    --to=mayhs11saini@gmail.com \
    --cc=Ariel.Elior@cavium.com \
    --cc=Yuval.Mintz@cavium.com \
    --cc=davem@davemloft.net \
    --cc=everest-linux-l2@cavium.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).