From: Steffen Klassert <steffen.klassert@secunet.com>
To: Colin King <colin.king@canonical.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xfrm: state: fix potential null pointer dereference on afinfo
Date: Mon, 16 Jan 2017 14:27:04 +0100 [thread overview]
Message-ID: <20170116132704.GQ3541@gauss.secunet.com> (raw)
In-Reply-To: <20170113140703.20961-1-colin.king@canonical.com>
On Fri, Jan 13, 2017 at 02:07:03PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> afinfo is being null checked before a call afinfo->init_tempsel
> so afinfo may be potentially null. ifinfo may still be null in
> the case were it is not updated when family == tmpl->encap_family,
> hence we may hit a null pointer dereference in the call to
> afinfo->init_temprop.
>
> Fix this by adding a null ptr check before calling init_temprop.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
I've applied already a fix for this from Florian Westphal.
Thanks a lot anyway!
prev parent reply other threads:[~2017-01-16 13:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 14:07 [PATCH] xfrm: state: fix potential null pointer dereference on afinfo Colin King
2017-01-16 13:27 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116132704.GQ3541@gauss.secunet.com \
--to=steffen.klassert@secunet.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).