From: Steffen Klassert <steffen.klassert@secunet.com>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <ofir.drang@arm.com>,
<gilad.benyossef@arm.com>,
Alexander Alemayhu <alexander@alemayhu.com>
Subject: Re: [PATCH ipsec-next v3 0/2] IPsec: do not ignore crypto err in ah input
Date: Mon, 16 Jan 2017 14:27:50 +0100 [thread overview]
Message-ID: <20170116132750.GR3541@gauss.secunet.com> (raw)
In-Reply-To: <1484565476-19371-1-git-send-email-gilad@benyossef.com>
On Mon, Jan 16, 2017 at 01:17:54PM +0200, Gilad Ben-Yossef wrote:
> ah input processing uses the asynchronous hash crypto API which
> supplies an error code as part of the operation completion but
> the error code was being ignored.
>
> Treat a crypto API error indication as a verification failure.
>
> While a crypto API reported error would almost certainly result
> in a memcpy of the digest failing anyway and thus the security
> risk seems minor, performing a memory compare on what might be
> uninitialized memory is wrong.
>
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
> CC: Alexander Alemayhu <alexander@alemayhu.com>
Both applied to ipsec-next, thanks a lot!
prev parent reply other threads:[~2017-01-16 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 11:17 [PATCH ipsec-next v3 0/2] IPsec: do not ignore crypto err in ah input Gilad Ben-Yossef
2017-01-16 11:17 ` [PATCH ipsec-next v3 1/2] IPsec: do not ignore crypto err in ah4 input Gilad Ben-Yossef
2017-01-16 11:17 ` [PATCH ipsec-next v3 2/2] IPsec: do not ignore crypto err in ah6 input Gilad Ben-Yossef
2017-01-16 13:27 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116132750.GR3541@gauss.secunet.com \
--to=steffen.klassert@secunet.com \
--cc=alexander@alemayhu.com \
--cc=davem@davemloft.net \
--cc=gilad.benyossef@arm.com \
--cc=gilad@benyossef.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=ofir.drang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).