From: David Miller <davem@davemloft.net>
To: leroi.lists@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [net, 3/6] net: korina: increase tx/rx ring sizes
Date: Tue, 17 Jan 2017 14:08:31 -0500 (EST) [thread overview]
Message-ID: <20170117.140831.246422739371129394.davem@davemloft.net> (raw)
In-Reply-To: <CACiydbLuVf_jsWor6-OJmwQhxfwd=dzBDnDQnJrp3owf8qCkQA@mail.gmail.com>
From: Roman Yeryomin <leroi.lists@gmail.com>
Date: Tue, 17 Jan 2017 20:27:57 +0200
> On 17 January 2017 at 19:58, David Miller <davem@davemloft.net> wrote:
>> From: Roman Yeryomin <leroi.lists@gmail.com>
>> Date: Tue, 17 Jan 2017 19:32:36 +0200
>>
>>> Having larger ring sizes almost eliminates rx fifo overflow, thus improving performance.
>>> This patch reduces rx overflow occurence by approximately 1000 times (from ~25k down to ~25 times per 3M frames)
>>
>> Those numbers don't mean much without full context.
>>
>> What kind of system, what kind of traffic, and over what kind of link?
>
> MIPS rb532 board, TCP iperf3 test over 100M link, NATed speed ~55Mbps.
> I can do more tests and provide more precise numbers, if needed.
Provide this information in the commit message on your respin of this patch
series after you've addressed all of the other feedback, don't tell me :-)
next prev parent reply other threads:[~2017-01-17 19:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 17:32 [net, 3/6] net: korina: increase tx/rx ring sizes Roman Yeryomin
2017-01-17 17:58 ` David Miller
2017-01-17 18:27 ` Roman Yeryomin
2017-01-17 19:08 ` David Miller [this message]
2017-01-17 19:20 ` Eric Dumazet
2017-01-19 10:55 ` Roman Yeryomin
2017-01-19 13:37 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117.140831.246422739371129394.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=leroi.lists@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox