From: David Miller <davem@davemloft.net>
To: leroi.lists@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [net, 2/6] net: korina: define NAPI_WEIGHT
Date: Tue, 17 Jan 2017 14:08:59 -0500 (EST) [thread overview]
Message-ID: <20170117.140859.841742831056887344.davem@davemloft.net> (raw)
In-Reply-To: <CACiydbLyswWZ2ZX04m22Ga_FBbp-52kxOxBbNcvS+R1d1Kdpcw@mail.gmail.com>
From: Roman Yeryomin <leroi.lists@gmail.com>
Date: Tue, 17 Jan 2017 20:30:44 +0200
> On 17 January 2017 at 19:40, David Miller <davem@davemloft.net> wrote:
>> From: Roman Yeryomin <leroi.lists@gmail.com>
>> Date: Tue, 17 Jan 2017 19:32:22 +0200
>>
>>> @@ -77,6 +77,8 @@
>>>
>>> #define MII_CLOCK 1250000 /* no more than 2.5MHz */
>>>
>>> +#define NAPI_WEIGHT 64
>>> +
>>> /* the following must be powers of two */
>>> #define KORINA_NUM_RDS 64 /* number of receive descriptors */
>>> #define KORINA_NUM_TDS 64 /* number of transmit descriptors */
>>> @@ -1080,7 +1082,7 @@ static int korina_probe(struct platform_device *pdev)
>>> dev->netdev_ops = &korina_netdev_ops;
>>> dev->ethtool_ops = &netdev_ethtool_ops;
>>> dev->watchdog_timeo = TX_TIMEOUT;
>>> - netif_napi_add(dev, &lp->napi, korina_poll, 64);
>>> + netif_napi_add(dev, &lp->napi, korina_poll, NAPI_WEIGHT);
>>
>> Please use NAPI_POLL_WEIGHT from linux/netdevice.h
>
> OK, should I resend the whole set or just this one and dependant?
You always must do this for any change whatsoever, a full respin of a
series is always required on any modification whatsoever to any patch.
prev parent reply other threads:[~2017-01-17 19:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 17:32 [net, 2/6] net: korina: define NAPI_WEIGHT Roman Yeryomin
2017-01-17 17:40 ` David Miller
2017-01-17 18:30 ` Roman Yeryomin
2017-01-17 18:32 ` Florian Fainelli
2017-01-17 19:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117.140859.841742831056887344.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=leroi.lists@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox