Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: pshelar@ovn.org, ashiduka@jp.fujitsu.com, fugang.duan@nxp.com,
	netdev@vger.kernel.org, pshelar@nicira.com
Subject: Re: [PATCH net] net: fix harmonize_features() vs NETIF_F_HIGHDMA
Date: Wed, 18 Jan 2017 15:25:14 -0500 (EST)	[thread overview]
Message-ID: <20170118.152514.1412023737192147746.davem@davemloft.net> (raw)
In-Reply-To: <1484770337.13165.120.camel@edumazet-glaptop3.roam.corp.google.com>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 18 Jan 2017 12:12:17 -0800

> From: Eric Dumazet <edumazet@google.com>
> 
> Ashizuka reported a highmem oddity and sent a patch for freescale
> fec driver.
> 
> But the problem root cause is that core networking stack
> must ensure no skb with highmem fragment is ever sent through
> a device that does not assert NETIF_F_HIGHDMA in its features.
> 
> We need to call illegal_highdma() from harmonize_features()
> regardless of CSUM checks.
> 
> Fixes: ec5f06156423 ("net: Kill link between CSUM and SG features.")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Pravin Shelar <pshelar@ovn.org>
> Reported-by: "Ashizuka, Yuusuke" <ashiduka@jp.fujitsu.com>

Applied, thanks Eric.

I guess few devices support SG and lack highmem support.

  reply	other threads:[~2017-01-18 20:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-17  7:48 [PATCH] net: fec: Fixed panic problem with non-tso Yuusuke Ashiduka
2017-01-17 11:02 ` Andy Duan
2017-01-18  3:12   ` Ashizuka, Yuusuke
2017-01-18  4:21     ` Eric Dumazet
2017-01-18  4:35       ` Eric Dumazet
2017-01-18 18:18         ` Pravin Shelar
2017-01-18 19:51           ` Eric Dumazet
2017-01-18 20:12             ` [PATCH net] net: fix harmonize_features() vs NETIF_F_HIGHDMA Eric Dumazet
2017-01-18 20:25               ` David Miller [this message]
2017-01-19  8:18         ` [PATCH] net: fec: Fixed panic problem with non-tso Andy Duan
2017-01-19 13:24           ` Eric Dumazet
2017-01-17 20:45 ` David Miller
2017-01-18  3:20   ` Ashizuka, Yuusuke
2017-01-18  4:11   ` [PATCH v2] " Yuusuke Ashiduka
2017-01-18  5:02     ` Eric Dumazet
2017-01-18  5:38       ` Andy Duan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170118.152514.1412023737192147746.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ashiduka@jp.fujitsu.com \
    --cc=eric.dumazet@gmail.com \
    --cc=fugang.duan@nxp.com \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@nicira.com \
    --cc=pshelar@ovn.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox