From: David Miller <davem@davemloft.net>
To: sainath.grandhi@intel.com
Cc: netdev@vger.kernel.org, mahesh@bandewar.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 3/7] TAP: Tap character device creation/destroy API
Date: Wed, 18 Jan 2017 16:26:47 -0500 (EST) [thread overview]
Message-ID: <20170118.162647.1034141344569503382.davem@davemloft.net> (raw)
In-Reply-To: <1484697786-50323-4-git-send-email-sainath.grandhi@intel.com>
From: Sainath Grandhi <sainath.grandhi@intel.com>
Date: Tue, 17 Jan 2017 16:03:02 -0800
> +int tap_create_cdev(struct cdev *tap_cdev,
> + dev_t *tap_major, const char *device_name)
> +{
> + int err;
> +
> + err = alloc_chrdev_region(tap_major, 0, TAP_NUM_DEVS, device_name);
> +
> + if (err)
> + goto out1;
No need to have an empty line between the alloc_chrdev_region() call
and the "if (err)" test.
> diff --git a/include/linux/if_tap.h b/include/linux/if_tap.h
> index d887aaa..a2dfd90 100644
> --- a/include/linux/if_tap.h
> +++ b/include/linux/if_tap.h
> @@ -10,7 +10,7 @@ struct file;
> struct socket;
> static inline struct socket *tap_get_socket(struct file *f)
> {
> - return ERR_PTR(-EINVAL);
> + return ERR_PTR(-EINVAL);
> }
Instead of having to fix up the indentation here, get it right in the first place
in patch #2.
next prev parent reply other threads:[~2017-01-18 21:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 0:02 [PATCHv2 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces Sainath Grandhi
2017-01-18 0:03 ` [PATCHv2 1/7] TAP: Refactoring macvtap.c Sainath Grandhi
2017-01-18 0:03 ` [PATCHv2 2/7] TAP: Renaming tap related APIs, data structures, macros Sainath Grandhi
2017-01-18 0:03 ` [PATCHv2 3/7] TAP: Tap character device creation/destroy API Sainath Grandhi
2017-01-18 21:26 ` David Miller [this message]
2017-01-19 23:33 ` Grandhi, Sainath
2017-01-18 0:03 ` [PATCHv2 4/7] TAP: Abstract type of virtual interface from tap implementation Sainath Grandhi
2017-01-18 21:27 ` David Miller
2017-01-18 0:03 ` [PATCHv2 5/7] TAP: Extending tap device create/destroy APIs Sainath Grandhi
2017-01-18 1:00 ` Andy Shevchenko
2017-01-18 0:03 ` [PATCHv2 6/7] TAP: tap as an independent module Sainath Grandhi
2017-01-18 0:03 ` [PATCHv2 7/7] IPVTAP: IP-VLAN based tap driver Sainath Grandhi
2017-01-18 21:28 ` David Miller
2017-01-19 23:33 ` Grandhi, Sainath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118.162647.1034141344569503382.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mahesh@bandewar.net \
--cc=netdev@vger.kernel.org \
--cc=sainath.grandhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox