From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: phy: bcm63xx: Utilize correct config_intr function Date: Wed, 18 Jan 2017 16:57:03 -0500 (EST) Message-ID: <20170118.165703.784321123769576826.davem@davemloft.net> References: <20170118002655.6865-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jonas.gorski@gmail.com, dgcbueu@gmail.com To: f.fainelli@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:41958 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752290AbdARV5U (ORCPT ); Wed, 18 Jan 2017 16:57:20 -0500 In-Reply-To: <20170118002655.6865-1-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Florian Fainelli Date: Tue, 17 Jan 2017 16:26:55 -0800 > From: Daniel Gonzalez Cabanelas > > Commit a1cba5613edf ("net: phy: Add Broadcom phy library for common > interfaces") make the BCM63xx PHY driver utilize bcm_phy_config_intr() > which would appear to do the right thing, except that it does not write > to the MII_BCM63XX_IR register but to MII_BCM54XX_ECR which is > different. > > This would be causing invalid link parameters and events from being > generated by the PHY interrupt. > > Fixes: a1cba5613edf ("net: phy: Add Broadcom phy library for common interfaces") > Signed-off-by: Daniel Gonzalez Cabanelas > Signed-off-by: Florian Fainelli Applied and queued up for -stable, thanks!