From: Andrew Lunn <andrew@lunn.ch>
To: YUAN Linyu <Linyu.Yuan@alcatel-sbell.com.cn>
Cc: Zefir Kurtisi <zefir.kurtisi@neratec.com>,
David Miller <davem@davemloft.net>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"cugyly@163.com" <cugyly@163.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: add regs attribute to phy device for user diagnose
Date: Thu, 19 Jan 2017 02:01:42 +0100 [thread overview]
Message-ID: <20170119010142.GB26959@lunn.ch> (raw)
In-Reply-To: <8729016553E3654398EA69218DA29EEF15A5A289@cnshjmbx04>
> I will add two ethtool command in kernel to read and write register in PHY.
Write access will get NACKed by me. Read only please.
> ethtool can use these command to dump what user want, there is no
> more work to PHY driver.
Please think about how you handle PHYs with pages. This needs to be
part of the API.
Andrew
next prev parent reply other threads:[~2017-01-19 1:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-14 2:46 [PATCH] net: add regs attribute to phy device for user diagnose yuan linyu
2017-01-14 16:24 ` Andrew Lunn
2017-01-14 18:35 ` Florian Fainelli
2017-01-15 1:51 ` yuan linyu
2017-01-15 1:57 ` Florian Fainelli
2017-01-15 10:40 ` yuan linyu
2017-01-15 17:21 ` Andrew Lunn
2017-01-16 12:59 ` yuan linyu
2017-01-16 20:22 ` Florian Fainelli
2017-01-16 21:54 ` David Miller
2017-01-17 0:11 ` YUAN Linyu
2017-01-18 12:37 ` Zefir Kurtisi
2017-01-19 0:45 ` YUAN Linyu
2017-01-19 1:01 ` Andrew Lunn [this message]
2017-02-11 3:48 ` yuan linyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119010142.GB26959@lunn.ch \
--to=andrew@lunn.ch \
--cc=Linyu.Yuan@alcatel-sbell.com.cn \
--cc=cugyly@163.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=zefir.kurtisi@neratec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).