From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] net: ethernet: aquantia: fix alloc_cast.cocci warnings Date: Thu, 19 Jan 2017 17:09:31 +0800 Message-ID: <20170119090931.GA28354@lkp-ne04.lkp.intel.com> References: <201701191708.e8q1JvlR%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild-all@01.org, netdev@vger.kernel.org, David VomLehn , "David S . Miller" , Simon Edelhaus , Alexander Loktionov , Dmitrii Tarakanov , Pavel Belous , Dmitry Bezrukov To: Alexander Loktionov Return-path: Received: from mga04.intel.com ([192.55.52.120]:15298 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751412AbdASJMi (ORCPT ); Thu, 19 Jan 2017 04:12:38 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: drivers/net/ethernet/aquantia/atlantic/aq_ring.c:24:20-41: WARNING: casting value returned by memory allocation function to (struct aq_ring_buff_s *) is useless. Remove casting the values returned by memory allocation functions like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc. Semantic patch information: This makes an effort to find cases of casting of values returned by kmalloc, kzalloc, kcalloc, kmem_cache_alloc, kmem_cache_zalloc, kmem_cache_alloc_node, kmalloc_node and kzalloc_node and removes the casting as it is not required. The result in the patch case may need some reformatting. Generated by: scripts/coccinelle/api/alloc/alloc_cast.cocci CC: David VomLehn Signed-off-by: Fengguang Wu --- aq_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c @@ -21,7 +21,7 @@ static struct aq_ring_s *aq_ring_alloc(s { int err = 0; - self->buff_ring = (struct aq_ring_buff_s *) + self->buff_ring = kzalloc(sizeof(struct aq_ring_buff_s) * self->size, GFP_KERNEL); if (!self->buff_ring) {