Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: acollins@cradlepoint.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, tom@herbertland.com
Subject: Re: [PATCH net-next] fq_codel: Avoid regenerating skb flow hash unless necessary
Date: Fri, 20 Jan 2017 12:15:37 -0500 (EST)	[thread overview]
Message-ID: <20170120.121537.2279655261253689807.davem@davemloft.net> (raw)
In-Reply-To: <20170118210428.24006-1-acollins@cradlepoint.com>

From: Andrew Collins <acollins@cradlepoint.com>
Date: Wed, 18 Jan 2017 14:04:28 -0700

> The fq_codel qdisc currently always regenerates the skb flow hash.
> This wastes some cycles and prevents flow seperation in cases where
> the traffic has been encrypted and can no longer be understood by the
> flow dissector.
> 
> Change it to use the prexisting flow hash if one exists, and only
> regenerate if necessary.
> 
> Signed-off-by: Andrew Collins <acollins@cradlepoint.com>

Applied, thanks.

  parent reply	other threads:[~2017-01-20 17:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18 21:04 [PATCH net-next] fq_codel: Avoid regenerating skb flow hash unless necessary Andrew Collins
2017-01-18 21:13 ` Eric Dumazet
2017-01-20 17:15 ` David Miller [this message]
2017-01-20 17:23 ` Tom Herbert
2017-01-20 17:31   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170120.121537.2279655261253689807.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=acollins@cradlepoint.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox